Adding objects to the generic list

Question

Hi I am trying to add same object with different property settings. But When Iterate through the List it gives me latest added Setting.

As you can see below is my code.

List<TestObject> list = new ArrayList<TestObject>();
TestObject  t= new TestObject();
t.setEmail("[email protected]");
list.add(t);
System.out.println(list.get(0).getEmail());
t.setEmail("The_lawyer99yahoo.com");
list.add(t);
System.out.println(list.get(1).getEmail());

for(TestObject s : list)
{
    System.out.println(s.getEmail());
}

Output:

[email protected]
The_lawyer99yahoo.com
The_lawyer99yahoo.com
The_lawyer99yahoo.com

What my doubt is why iteretor is giving latest added Object seting (email) But When I excute this statement System.out.println(list.get(0).getEmail()); its working fine

Why is for loop just keep returning with recently added object ?

Thanks in advance.

You're not creating a new object, but simply changing properties of the same object in memory. List will allow you to add the same instance of a Object multiple times, so it can "look" like you've added multiple objects when in fact, it's just a bunch of elements pointing to the same object. Use a Set of some kind instead and you will find you only have a single object ;) — MadProgrammer
– MadProgrammer, Commented Jul 21, 2015 at 5:47
you have the same objet t, so is the same reference, you have to make a new one before set the 2 email — nicearma
– nicearma, Commented Jul 21, 2015 at 5:48

MadProgrammer · Accepted Answer · 2015-07-21 05:49:50Z

You're not creating a new object, but simply changing properties of the same object in memory. List will allow you to add the same instance of a Object multiple times, so it can "look" like you've added multiple objects when in fact, it's just a bunch of elements pointing to the same object. Use a Set of some kind instead and you will find you only have a single object ;)

You would need to create a new instance of the TestObject for each new entry, for example...

List<TestObject> list = new ArrayList<TestObject>();
TestObject  t= new TestObject();
t.setEmail("[email protected]");
list.add(t);
System.out.println(list.get(0).getEmail());

t= new TestObject();
t.setEmail("The_lawyer99yahoo.com");
list.add(t);
System.out.println(list.get(1).getEmail());

for(TestObject s : list)
{
   System.out.println(s.getEmail());
}

This way, the properties are associated with a different instance of the TestObject for each entry

Jonas Leeb · Accepted Answer · 2015-07-21 05:49:53Z

2

I guess Java only places a reference to the object into your list so as youre changing the properties of your element it affects the list contents as well.

answered Jul 21, 2015 at 5:49

Jonas Leeb

362 bronze badges

Comments

skypjack · Accepted Answer · 2015-07-21 05:55:55Z

0

Your problem is called aliasing. When you submit your object t to the container, it's actually interested in the reference of your object. Because of that, the item at position 0 and the one at position 1 are exactly the same, because you stored the same reference at the same object twice instead of two different objects. Thus when you modify t you are actually modifying the sole object created till now, and both the references will show the updated date.

To solve it, simply create a new object and add it to the list by using the following line (as you already do the first time):

t = new TestObject();

answered Jul 21, 2015 at 5:55

skypjack

50.9k19 gold badges108 silver badges203 bronze badges

Collectives™ on Stack Overflow

Adding objects to the generic list

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related