PHP Login Form (no sql) - Validated against text file records - Not validating

Question

I'm working on a log in form that users a text file (users.txt) to validate username/password against. I cannot use MYSQL for this.

The text file records are in this format:

user one:[email protected]:user1:password1

user two:[email protected]:user2:password2

If it validate just the USERNAME only, then it successfully checks the user: if ($currUser == $userUsername) {$valid = true; break;}BUT if I then try to validate both username and password I get the wrong result.($currUser == $userUsername && $currPass == $userPass) {$valid = true; break;} Results in "Invalid username or password"

I can't figure out what I'm doing wrong? When I echo the username and passwords they are a match!!!

SCRIPT:

if(isset($_POST['submit'])){
   $form_is_submitted = true;

   //FORM PROCESSING
   if(isset($_POST['userName']) && isset($_POST['password'])) {

      $currUser = $_POST['userName'];
      $currPass = $_POST['password'];
      $valid = false;//flag
      while (!feof($fileHandle)) {
          $userRow = fgets($fileHandle);
          $userDetails = explode(':', $userRow);
          if (!isset($userDetails[2])) {
              $userDetails[2] = null;
          }
          if (!isset($userDetails[3])) {

              $userDetails[3] = null;
          }
          $userUsername = $userDetails[2];
          $userPass = $userDetails[3];
          if ($currUser == $userUsername /*&& $currPass == $userPass*/) {
              $valid = true;
              //break;
          }
      }    
      if ($valid) {
         echo "<br> $userUsername logged in sucessfully<br>";
      } else {
         echo "<br>Invalid user name or password<br>";
         //FOR DEGUGGING ONLY!
         echo $currUser . $userUsername;
         echo $currPass . $userPass;
         echo $_POST['password'];
         echo $_POST['userName'];

      }
  } else {    
     $errors_detected = true;
     $errors['not set'] = "Please enter username and password";
  }

}

Maybe you got some special character (line feed or whatever) in the password string. Have you tried using trim() on $userPass? — t.h3ads
– t.h3ads, Commented Jul 27, 2015 at 15:15
@Typoheads great shout! 8 hours messing around with this and all that was needed was trim() — Maurice Greenland
– Maurice Greenland, Commented Jul 27, 2015 at 15:26

x4rf41 · Accepted Answer · 2015-07-27 15:24:47Z

2

the fgets() function returns a line INCLUDING the linefeed \n (and the carriage return \r if its there). that means you have to remove those.

just change this:

$userPass = $userDetails[3];

to this:

$userPass = trim($userDetails[3]);

and it should work

answered Jul 27, 2015 at 15:24

x4rf41

5,3672 gold badges24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP Login Form (no sql) - Validated against text file records - Not validating

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related