I can't input values to the array

Question

Scanner input = new Scanner(System.in);
    System.out.println("What dimensions do you need");
    int z = input.nextInt();
    int y = input.nextInt();
    int[][] x = new int[z][y];
    for (int i = 0; i <= z; i++) {
        for (int j = 0; j <= y; j++) {
            System.out.println("What number do you want in " + i + " , "
                    + j);
            x[i][j] = input.nextInt();

        }
    }

After i reach a specific dimension, the program stops. if i enter the dimensions (1,1), it won't let me add values to (1,1); i can only input values for 0,0 and 0,1. How can i solve this?

Is it giving you an error when it stops? Try searching for that (either on this site or in Google at large). — Reinstate Monica -- notmaynard
– Reinstate Monica -- notmaynard, Commented Jul 27, 2015 at 22:46
Also, docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html — Reinstate Monica -- notmaynard
– Reinstate Monica -- notmaynard, Commented Jul 27, 2015 at 22:47
Note to high-rep users: I'm sure you're aware that this question has been asked and answered repeatedly on this site. Please vote to close as duplicate instead of posting yet another answer saying the same thing. — Reinstate Monica -- notmaynard
– Reinstate Monica -- notmaynard, Commented Jul 27, 2015 at 22:50

Elliott Frisch · Accepted Answer · 2015-07-27 22:47:12Z

3

Arrays start at 0. You need less than, not less than equal. Change

for (int i = 0; i <= z; i++) {
    for (int j = 0; j <= y; j++) {

to

for (int i = 0; i < z; i++) {
    for (int j = 0; j < y; j++) {

and dimensions 1,1 would be space for a single array of length 1 containing an array of length 1. Increase the size of any dimension to add more than one value.

answered Jul 27, 2015 at 22:47

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

RadijatoR · Accepted Answer · 2015-07-27 22:47:01Z

0

It's because you alloced less memory for your array.

answered Jul 27, 2015 at 22:47

RadijatoR

1139 bronze badges

Comments

Ankur Shanbhag · Accepted Answer · 2015-07-27 22:48:07Z

0

Look at your for loops:

for (int i = 0; i <= z; i++) {
        for (int j = 0; j <= y; j++) {

It should be

for (int i = 0; i < z; i++) {
        for (int j = 0; j < y; j++) {

answered Jul 27, 2015 at 22:48

Ankur Shanbhag

7,8042 gold badges31 silver badges38 bronze badges

Comments

Jack · Accepted Answer · 2015-07-27 22:49:16Z

0

Arrays in most programming languages have 0 based indices.

This means that a int[+ a = new int[2] has two elements at index 0 and 1. So a[0] is a valid index, a[1] is valid too but a[2] is not. In addition this means that when you iterate over an array you don't need to use <= but < as condition on the index, because, for example

for (int i = 0; i <= 3; ++i)

will iterate for values of i = 0, 1, 2, 3, but 3 is an invalid index in a new int[3], so you need to do for (int i = 0; i < 3; ++i).

answered Jul 27, 2015 at 22:49

Jack

134k33 gold badges252 silver badges349 bronze badges

Collectives™ on Stack Overflow

I can't input values to the array

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related