any() all() function in python

Question

Write a function isAllLettersUsed(word, required) that takes in a word as the first argument and returns True if the word contains all the letters found in the second argument.

Examples

>>> isAllLettersUsed('apple', 'apple')
True
>>> isAllLettersUsed('apple', 'google')
False
>>> isAllLettersUsed('learning python', 'google')
True
>>> isAllLettersUsed('learning python', 'apple')
True

What i'm Doing is

def isAllLettersUsed(word, required):
    if all(required in word for required in word):
        return True
    else: 
        return False

And Result returning is

True
True
True
True

Where as it should return as

True
False
True
True

i don't understand what should i do at this point i have tried many things but failed. any suggestion??

for required in word means "for each letter in word, assign it to a variable named required (and incidentally shadow the old one)." You probably want to use for ch in required or something similar. — Colonel Thirty Two
– Colonel Thirty Two, Commented Jul 28, 2015 at 18:39

Padraic Cunningham · Accepted Answer · 2015-07-28 20:23:17Z

5

Just see if all letters in required are in word:

def  isAllLettersUsed(word, required):
    return all(ch in word for ch in required)

You are checking if the each letter from word is in word by using required in your for loop, required refers to each character not the required parameter passed so it always returns True as every letter from word has to be in the word.

edited Jul 28, 2015 at 20:23

answered Jul 28, 2015 at 18:38

Padraic Cunningham

181k30 gold badges264 silver badges327 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Padraic Cunningham Over a year ago

No worries, you could use sets which for large strings would be more efficient but I think that is getting away from the main point of your question

Jeremy Fisher · Accepted Answer · 2015-07-28 18:56:26Z

1

def isAllLettersUsed(word, required):
    if all(req in word for req in required):
        return True
    else: 
        return False

What happened was that you were assigning a value to the variable required in your for loop but required is a parameter. You want to loop through required and save each element of required to a new variable. Then, check if that element is in word.

Additionally, your if-else is redundant if you use all(). Just say return all(...)

edited Jul 28, 2015 at 18:56

answered Jul 28, 2015 at 18:40

Jeremy Fisher

2,8027 gold badges39 silver badges71 bronze badges

Comments

dsh · Accepted Answer · 2015-07-28 18:39:32Z

0

Change the name of your variables in your generator expression. You shadowed your argument named required with your loop variable required.

answered Jul 28, 2015 at 18:39

dsh

12.3k3 gold badges37 silver badges53 bronze badges

Collectives™ on Stack Overflow

any() all() function in python

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related