Getting wrong information when scraping XML with Linq

Question

Image I have this XML:

<ipb>
    <profile>
        <id>335389</id>
        <name>stapia.gutierrez</name>
        <rating>0</rating>
    </profile>
</ipb>

I'm trying to get ID, Name and Rating. Any guidance?

Here's what I have and what I receive:

public User FindInformation()
{
  string xml = new WebClient().DownloadString(String.Format("http://www.dreamincode.net/forums/xml.php?showuser={0}", userID));
  XDocument doc = XDocument.Parse(xml);

  var id = from u in doc.Descendants("profile")
                 select (string)u.Element("id");

  var name = from u in doc.Descendants("profile")
                 select (string)u.Element("name");

  var rating = from u in doc.Descendants("profile")
                 select (string)u.Element("rating");

  User user = new User();
  user.ID = id.ToString();
  user.Name = name.ToString();
  user.Rating = rating.ToString();

  return user;
}

This is what I get in my TextBox for testing purposes.

System.Linq.Enumerable+WhereSelectEnumerableIterator`2[System.Xml.Linq.XElement,System.String] System.Linq.Enumerable+WhereSelectEnumerableIterator`2[System.Xml.Linq.XElement,System.String] System.Linq.Enumerable+WhereSelectEnumerableIterator`2[System.Xml.Linq.XElement,System.String]

marc_s · Accepted Answer · 2010-07-04 19:21:05Z

1

You need to extract a single instance of <profile> and then operate on that:

XDocument doc = XDocument.Parse(xml);

foreach(var profile in doc.Descendants("profile"))
{
   var id = profile.Element("id").Value;
   var name = profile.Element("name").Value;
   var rating = profile.Element("rating").Value;

   User user = new User();
   user.ID = id;
   user.Name = name;
   user.Rating = rating;
}

What you're doing now is selecting a list of nodes (doc.Descendants("profile") will return a list of nodes, possibly with just one element - but still a list), and then all the "id" elements from within that list.... not really what you want, I guess!

answered Jul 4, 2010 at 19:21

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sergio Tapia Over a year ago

Thanks, this is just what I needed. Haven't worked with XML much. :]

Sergio Tapia Over a year ago

Don't worry I always do. Timer has 8 minutes before I can accept.

Erik Funkenbusch Over a year ago

the system requires a certain amount of time to pass before an aswer can be marked answered. Don't jump the gun.

marc_s Over a year ago

Thanks - I do know about the time limit but that seemed to me had pass long ago - guess I'm getting too impatient! Thanks, Sergio.

shahkalpesh · Accepted Answer · 2010-07-04 19:21:55Z

0

var id = from u in doc.Descendants("profile")
select (string)u.Element("id");

This & other statements like these will return you an enumerable & not a specific instance. i.e what happens, if your xml has many nodes that satisfy the condition?

So, if you are looking to get the first item (or if you have a xml structure exactly as shown above with no extra nodes), a call to First or FirstOrDefault should help.

answered Jul 4, 2010 at 19:21

shahkalpesh

33.6k4 gold badges66 silver badges89 bronze badges

Collectives™ on Stack Overflow

Getting wrong information when scraping XML with Linq

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related