Using Singleton in Constructor

Question

I have a Singleton Logger class.

public class Logger {
  public static Logger INSTANCE = new Logger();

  private Logger() {
    ...
  }
}

I want to log in my constructor that a new instance is created. So my code looks like:

public class MyClass {
  public MyClass() {
    Logger.INSTANCE.log("MyClass created");
    ...
  }
}

I am wondering if this could break static instances of MyClass. For instance, if I have:

public class MyOtherClass {
  private static MyClass myClass = new MyClass();
  ...
}

I fear that this could cause a problem due to undefined order of initialization of static variables. So if myClass is initialized before Logger.INSTANCE is, then the construction of myClass will crash. Is there some mechanism to prevent this from happening or is using static variables in a constructor inherently dangerous? Is there any way to prevent users from creating static instances of MyClass in such a case?

If you must use a singleton pattern, the instance itself shouldn't be available. It should he wrapped in a method. — christopher
– christopher, Commented Aug 2, 2015 at 8:24
Note that in this case, your instance variable should be final and either private or protected. — chrylis -cautiouslyoptimistic-
– chrylis -cautiouslyoptimistic-, Commented Aug 2, 2015 at 8:34

Community · Accepted Answer · 2017-05-23 11:43:54Z

4

public class Logger {
  public static Logger INSTANCE = new Logger();

  private Logger() {
    ...
  }
}

Is syntactic sugar for

public class Logger {
  public static Logger INSTANCE;
  static {
      INSTANCE = new Logger();
  }

  private Logger() {
    ...
  }
}

A static block sets up static members of the class, and is guaranteed to run before your class is used.

edited May 23, 2017 at 11:43

CommunityBot

11 silver badge

answered Aug 2, 2015 at 8:22

George Simms

4,0804 gold badges24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alon Zilberman · Accepted Answer · 2015-08-02 08:35:22Z

1

I recommend you to wrap your Logger.INSTANCE like in classic singleton:

public class Logger{

  private static Logger logger;

  private Logger(){

  }

  public static Logger getInstance(){
     if(logger==null){
         logger = new Logger();
     }
    return logger;
  }

}

This way when you will call Logger.getInstance() you will never get null.

If you need thread safe singleton:

public class Logger {
    private static class Holder {
        static final Logger INSTANCE = new Logger();
    }

    public static Logger getInstance() {
        return Holder.INSTANCE;
    }
}

This way you also will never get null because by default Logger will be initialized before class where it will be used, because in this case it will be dependency of other class.

edited Aug 2, 2015 at 8:35

answered Aug 2, 2015 at 8:22

Alon Zilberman

2,1551 gold badge16 silver badges16 bronze badges

1 Comment

George Simms Over a year ago

Also, lazy loading isn't an explicit requirement.

Peter Lawrey · Accepted Answer · 2015-08-02 08:21:46Z

0

So if myClass is initialized before Logger.INSTANCE is, then the construction of myClass will crash.

You can't initialise a class until all the classes it depends on have been initialised.

Is there some mechanism to prevent this from happening or is using static variables in a constructor inherently dangerous?

You can't use a class before it has been initialised (unless you call it in the initialisation code)

Is there any way to prevent users from creating static instances of MyClass in such a case?

You can't construct an instance of a class, until the classes it uses have been initialised.

answered Aug 2, 2015 at 8:21

Peter Lawrey

535k83 gold badges770 silver badges1.2k bronze badges

Comments

daz · Accepted Answer · 2015-08-02 08:33:05Z

0

No need to worry about breaking anything, JVM will ensure the correct order of construction. However there is a risk multiple instances are created if accessed my many threads. Improve the code my declaring the singleton as final and using an static method to access:

public class Logger {
  private static final Logger INSTANCE = new Logger();

  private Logger() {}

  public static Logger getInstance() {
      return INSTANCE;
  }
}

answered Aug 2, 2015 at 8:33

daz

1612 bronze badges

Collectives™ on Stack Overflow

Using Singleton in Constructor

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related