passing string variable in New-item -path

Question

I was writing this code to capture newly created AD's samaccountname and make a homefolder for it ! im facing this issue -

$ADServer= 'xyz'

$c = Get-EventLog Security -computername $ADServer -After (Get-Date).AddHours(-24) | Where-Object { $_.EventID -eq 4720 -and $_.Message -match "sam account name:\s+(.*)"} | ForEach-Object { $matches[1] } | Select-Object -First 1

New-Item -ItemType Directory -Path "\\abc\$c"

this is showing error - illegal characters in string, how can I create the folder of the same thing I captured in $c ?

What does $c contain? I suspect it is currently an object, therefore you may need to select the specific property for this to work — arco444
– arco444, Commented Aug 3, 2015 at 9:38
$c contains the samaccountname of the newly created AD user (U can check this in eventlog for eventid - 4720) — Martin Wood
– Martin Wood, Commented Aug 3, 2015 at 9:40
Can you edit the question and post the entire output to the console when you type $c? If it is displayed in a table show what the columns are. — arco444
– arco444, Commented Aug 3, 2015 at 9:41
no, typing $c gives just the samaccountname - i mean no table , no nothing, just the string and the error is new-item : illegal characters in path. InvalidArgument : (\\abc\xyz:string) — Martin Wood
– Martin Wood, Commented Aug 3, 2015 at 9:49
So what is the entire path then? Simplifying to \\abc\xyz might not be sufficient here if you're having this issue. You need to show exactly what these variables contain. Does it work if you manually run the New-Item command? — arco444
– arco444, Commented Aug 3, 2015 at 9:54

Avshalom · Accepted Answer · 2015-08-03 12:26:29Z

1

Try this one:

New-Item -ItemType Directory -Path "\\abc\c$\$($c.Trim())"

or:

$c = $c.trim()
New-Item -ItemType Directory -Path "\\abc\$c"

The Reason: You have extra space letter at the end, this is why it fails,

Use the $c.trim() or $c -replace "\s" to remove the the space char

edited Aug 3, 2015 at 12:26

answered Aug 3, 2015 at 10:35

Avshalom

8,9471 gold badge29 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Martin Wood Over a year ago

GREAT! this is the answer, thanks! sheesh, how did I miss that!

Matt Over a year ago

trim() would be better than your -replace here since there could be legitimate spaces in the path. You could do -replace "\s+$" just in case.

Avshalom Over a year ago

That's a good point but in the scenario of SAMAccountName Space is not an option

Collectives™ on Stack Overflow

passing string variable in New-item -path

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related