One ajax for multiple function names

Question

I have ShowExpired() and SessionDestroy() functions running the same jquery. Only difference: I have if statement in ShowExpired().

How can we shrink it?

function ShowExpired() {
    if (isextend == false) {
        $.ajax({
            type: "POST",
            cache: false,
            url: "../../html/frmLogout.aspx/Sessionlogout",
            data: "{userid:" + userid + "}",
            contentType: 'application/json; charset=utf-8',
            dataType: "json",
            async: false,
            success: function (data, e, jqxhr) {
                if (data.d.result) {
                    window.location.href = '../HTML/frmLogin.aspx';
                }
            },
            error: function (data, e, jqxhr) { alert("logout ERROR=" + data.responseText); }
        });
    }

}


function SessionDestroy() {

        $.ajax({
            type: "POST",
            cache: false,
            url: "../../html/frmLogout.aspx/Sessionlogout",
            data: "{userid:" + userid + "}",
            contentType: 'application/json; charset=utf-8',
            dataType: "json",
            async: false,
            success: function (data, e, jqxhr) {
                if (data.d.result) {
                    window.location.href = '../HTML/frmLogin.aspx';
                }
            },
            error: function (data, e, jqxhr) { alert("logout ERROR=" + data.responseText); }
        });

}

If both the functions does the same thing then why do you need to check with if? because none of the ajax part changes like url,data etc.. Then why you need if statement here? — Guruprasad J Rao
– Guruprasad J Rao, Commented Aug 7, 2015 at 3:50

Community · Accepted Answer · 2017-05-23 12:30:09Z

0

I had to run it in diffchecker just to make sure. :D https://www.diffchecker.com/jcknyfg4

In this case your first function could shrinked to:

function ShowExpired() {
    if (isextend == false) {
        SessionDestroy();
    }
}

In your example case this is easy. In general case, there are plenty of options to make an ajax call more readable and occupy less space in your code. Google it!

Some pointers:

https://github.com/yaymukund/jquery-ajax-wrap

https://lostechies.com/derickbailey/2012/05/04/wrapping-ajax-in-a-thin-command-framework-for-backbone-apps/

Wrap jQuery's $.ajax() method to define global error handling

Of course writing your own wrapper is also an option. The complexity of it is not high.

edited May 23, 2017 at 12:30

CommunityBot

11 silver badge

answered Aug 7, 2015 at 4:57

DDan

8,3566 gold badges38 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

One ajax for multiple function names

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related