Jquery each function only working once

Question

I have the following jquery function. It will only update the first row and then stops. Strangely though if i take out the line:

$("#prev_loan_approval_date").html("Not Yet Approved");

and replace it with an alert it fires off for each row. Is there any reason why this would be the case. Was thinking it mightnt return true on the next iteration because i changed the text value but this was for the previous row so the next row should still return true and change the value.

$(document).ready(function() {
    $('.loan_history_application > tbody  > tr').each(function() 
    {
        if ($("#prev_loan_approval_date").text() == "01/01/1900")
        {
            $("#prev_loan_approval_date").html("Not Yet Approved");
        };
    });

Can you also show the HTML?

Scott
– Scott

2015-08-13 10:02:05 +00:00
Commented Aug 13, 2015 at 10:02 — Scott
– Scott, Commented Aug 13, 2015 at 10:02

kiko · Accepted Answer · 2015-08-13 10:03:26Z

2

tr has a child "#prev_loan_approval_date"? If yes, you must write

$(document).ready(function() {
    $('.loan_history_application > tbody  > tr').each(function() 
    {
        if ($(this).find("#prev_loan_approval_date").text() == "01/01/1900")
        {
            $(this).find("#prev_loan_approval_date").html("Not Yet Approved");
        };
    });

answered Aug 13, 2015 at 10:03

kiko

723 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Dal Hundal Over a year ago

This doesn't address the fact that there shouldn't be multiple elements with the same ID

user3385136 Over a year ago

@kiko That did it for me. Thanks. Will mark it as correct in 4 minutes...when it lets me.

Dal Hundal Over a year ago

HTML ID's must be unique per page. This is letting you have the same ID exist in every row. It may appear to work due to browser quirk, but it is not right.

Chrillewoodz · Accepted Answer · 2015-08-13 10:02:15Z

0

The problem is likely to be that you use an ID instead of class for $("#prev_loan_approval_date").html("Not Yet Approved"); so it will only update the first row.

Change this to:

$(".prev_loan_approval_date").html("Not Yet Approved");

And make sure you also change ID to class in your HTML.

answered Aug 13, 2015 at 10:02

Chrillewoodz

28.5k23 gold badges102 silver badges189 bronze badges

1 Comment

Dal Hundal Over a year ago

This doesn't search for that element per row

Dal Hundal · Accepted Answer · 2015-08-13 10:05:47Z

Was thinking it mightnt return true on the next iteration because i changed the text value but this was for the previous row

No, this isn't for the previous row. There's several things wrong here. Firstly the fact that you're using an ID for something that seems to occur more than once (ID's must be unique). You should use a class.

Secondly, where you're changing the text - you're not doing it just for that row. You're always doing it on every row.

$(document).ready(function() {
$('.loan_history_application > tbody  > tr').each(function() {
    if ($(".prev_loan_approval_date", this).text() == "01/01/1900")
    {
        $(".prev_loan_approval_date",this).html("Not Yet Approved");
    };
});

And in your HTML change id='prev_load_approval_date' to class='prev_loan_approval_date'

Praveen Kumar Purushothaman · Accepted Answer · 2015-08-13 10:09:53Z

0

If you have multiple items with the same ID, it doesn't work. IDs should be unique. Change them to class and change in your code:

$(".prev_loan_approval_date").html("Not Yet Approved");

Full Code:

$(document).ready(function() {
    $('.loan_history_application > tbody  > tr').each(function() {
        if ($(this).find(".prev_loan_approval_date").text() == "01/01/1900")
            $(this).find(".prev_loan_approval_date").html("Not Yet Approved");
    });
});

edited Aug 13, 2015 at 10:09

answered Aug 13, 2015 at 10:03

Praveen Kumar Purushothaman

167k27 gold badges215 silver badges261 bronze badges

3 Comments

Dal Hundal Over a year ago

This doesn't search for that element per row

Praveen Kumar Purushothaman Over a year ago

The full code is in the question. If you want, I can update my answer with the full one.

Praveen Kumar Purushothaman Over a year ago

@DalHundal Have a look now.

Collectives™ on Stack Overflow

Jquery each function only working once

4 Answers 4

3 Comments

1 Comment

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

1 Comment

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related