Trouble with html input box

Question

I'm making a basic usd converter for practice in html/javascript. However when I select the euro option it does the same as for the peso option.

<html>
    <head>
        <title>Currency Converter</title>
        <style>

        </style>
    </head>
    <body>
        <input id="amount"> </input>
        <p>usd Contverted to</p> 
        <p class="output"> </p>
        <select id="select"> <option value="1">Peso's</option> <option value="2">Euro's</option> </select>
        <p id="answer"> is </p>
        <input type="submit" value="Submit" onclick="run()"> 
        <script>
            function run() {
                var Amount = document.getElementById("amount").value;
                if (select = 1) {
                    document.getElementById("answer").innerHTML = "=-=-= " + Amount * 16.39  + "   =-=-=";
                } else if (select = 2) {
                    document.getElementById("answer").innerHTML = "=-=-= " + Amount * 0.9  + "   =-=-=";
                } else {
            }
        </script>
    </body>
</html>

check this url jsbin.com/nipelezugu/edit?html,js,output

Naveen Kumar Alone
– Naveen Kumar Alone

2015-08-14 07:52:41 +00:00
Commented Aug 14, 2015 at 7:52 — Naveen Kumar Alone
– Naveen Kumar Alone, Commented Aug 14, 2015 at 7:52

Niko · Accepted Answer · 2015-08-14 07:41:04Z

1

You are not comparing select,you are setting it.

   if (select == 1) {
       document.getElementById("answer").innerHTML = ...
   } else if (select == 2) {

= -> setting a value
== -> comparing

answered Aug 14, 2015 at 7:41

Niko

6,2692 gold badges40 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mohit Bhardwaj · Accepted Answer · 2015-08-14 07:43:01Z

1

it should be select == 1 select=1 will always return true, because this way you are simply assigning a value, not checking for equality

answered Aug 14, 2015 at 7:43

Mohit Bhardwaj

10.1k7 gold badges41 silver badges66 bronze badges

Comments

Naveen Kumar Alone · Accepted Answer · 2015-08-14 08:02:44Z

0

You are not getting value of select
You are not comparing select value in if condition, make it as select == 1 and select == 2

Complete solution here

Change your javaScript function as below

function run() {
  var Amount=document.getElementById("amount").value;
  var select=document.getElementById("select").value;
  if (select == 1) {
    document.getElementById("answer").innerHTML = "=-=-= " + Amount * 16.39  + "   =-=-=";
  } else if (select == 2) {
    document.getElementById("answer").innerHTML = "=-=-= " + Amount * 0.9  + "   =-=-=";
  } else {
  }
}

edited Aug 14, 2015 at 8:02

answered Aug 14, 2015 at 7:44

Naveen Kumar Alone

7,6985 gold badges40 silver badges59 bronze badges

Collectives™ on Stack Overflow

Trouble with html input box

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related