Validating user input in batch

Question

I've got a simple batch script:

@echo off
set cash=500
:a
set name=
set /p input=Enter your name:
echo %name%
goto :a

I know batch input is prone to exploitation,and I've read a lot of articles on that. I can stop the user from just typing input&&set cash=100000 but how do i stop the batch file from closing if the user enters the | character?

I've added a lot of validation code, (even stopping the user from typing "set variable=" among other things. But it's that darn "|" that's the problem. — Jahwi
– Jahwi, Commented Aug 15, 2015 at 19:48

foxidrive · Accepted Answer · 2015-08-15 19:51:18Z

2

The problem is the echo command, not the input routine.
Double quotes fixes that - there are other ways.

@echo off
set cash=500
:a
set name=
set /p name=Enter your name:
echo "%name%"
goto :a

answered Aug 15, 2015 at 19:51

foxidrive

41.4k11 gold badges61 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jahwi Over a year ago

nice. but that does not stop the "|" problem now does it? Maybe i should pipe a c++ exe that does what i want.

foxidrive Over a year ago

Yes, it stops the problem that you asked about. Being unaware about echoing poison characters is where you were tripped up.

Collectives™ on Stack Overflow

Validating user input in batch

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related