jquery. something wrong with syntax?

Question

$('#buttons1').on('click', function(event) {             

    $('#button1content').toggle('show');
    var wasVisible = $("#button1content").is(":visible");
    if(!wasVisible) {
        $("#buttons1").css("opacity", "0.5");
    }
});

Toggle works perfectly fine, but whatever is inside the if statement doesn't get executed when #button1content is no longer visible. boo. It could be another part of my code that is messing it up, but I only want to know if there is anything wrong with this.

Typo? Did you mean to pass 'slow' vs. 'show'? If that's not meant to be a duration, .toggle() can be called without arguments to change whether the element is showing or hiding. — Jonathan Lonowski
– Jonathan Lonowski, Commented Aug 19, 2015 at 3:12

Dyrandz Famador · Accepted Answer · 2015-08-19 03:59:36Z

2

your variable wasVisible will always return a true

you can place the toggle on the last part.

you can reorder your code like this.

$('#buttons1').on('click', function(event) {             

    var wasVisible = $("#button1content").is(":visible");
    if(!wasVisible) {
        $("#buttons1").css("opacity", "0.5");
    }
    $('#button1content').toggle('show'); 
});

JSFIDDLE DEMO

OR

just simply remove the 'show' on the toggle just use

$('#button1content').toggle();

like this:

$('#buttons1').on('click', function(event) {             

    $('#button1content').toggle();
    var wasVisible = $("#button1content").is(":visible");
    if(!wasVisible) {
        $("#buttons1").css("opacity", "0.5");
    }
});

JSFIDDLE DEMO

edited Aug 19, 2015 at 3:59

answered Aug 19, 2015 at 2:51

Dyrandz Famador

4,5256 gold badges28 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Anonymous Duck · Accepted Answer · 2015-08-19 02:31:54Z

1

The if statement is not reachable because you always showed button1content

 $('#button1content').toggle('show');

So var wasVisible = $("#button1content").is(":visible"); will always result to true

answered Aug 19, 2015 at 2:31

Anonymous Duck

3,0081 gold badge14 silver badges35 bronze badges

7 Comments

Anik Islam Abhi Over a year ago

if statement doesn't get executed when #button1content is no longer visible ?

Anik Islam Abhi Over a year ago

how toggle always show ?? what's the purpose of using toggle ?

Anonymous Duck Over a year ago

everytime button is clicked, button1content is always visible,

Anonymous Duck Over a year ago

then? tell me whats your opinion

Sudhansu Choudhary Over a year ago

@Euphoria, you did spot the problem but your answer could be modified to say that, the if statement always results to be falsey because wasVisible is always true. If statement is not reachable is misleading :)

|

Collectives™ on Stack Overflow

jquery. something wrong with syntax?

2 Answers 2

Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related