loop and put array within array according to id failed

Question

var sports = [{
    "id": 1,
        "name": "baseball"
}, {
    "id": 2,
        "name": "Football"
}];

var playersData = [{
    "sport_id": 2,
        "id": "nv12",
        "name": "James"
}, {
    "sport_id": 2,
        "id": "nv11",
        "name": "Jean"
}];

var arr = [],
    tempObj = {};

$.each(sports, function (i, obj) {
    var sport_id = obj.id;

    $.each(playersData, function (i, obj) {
        if (sport_id == obj.sport_id) {
            tempObj = {
                "sport_id": obj.sport_id,
                    "id": obj.id,
                    "name": obj.name
            };
            arr.push(tempObj);
        }

    });
    obj.players = arr;
});

console.log(sports);

I try to build an array of players and put them within sports group according to sport_id but above logic has failed. It didn't group properly, the player who's in sport_id = 1 should go to sport which its id = 1 but why it didn't?

what's wrong with above loop there?

@NinaScholz the player who's in sport_id = 1 should go to sport which its id = 1. — tony yew
– tony yew, Commented Aug 19, 2015 at 9:29

Nina Scholz · Accepted Answer · 2015-08-19 09:36:33Z

2

I suppose this is what you want:

var sports = [{
    "id": 1,
    "name": "baseball"
}, {
    "id": 2,
    "name": "Football"
}];

var playersData = [{
    "sport_id": 2,
    "id": "nv12",
    "name": "James"
}, {
    "sport_id": 2,
    "id": "nv11",
    "name": "Jean"
}];

sports.forEach(function (a) {
    var arr = [];
    playersData.forEach(function (b) {
        if (a.id == b.sport_id) {
            arr.push(b);
        }
    });
    a.players = arr;
});

document.write('<pre>' + JSON.stringify(sports, 0, 4) + '</pre>');

answered Aug 19, 2015 at 9:36

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

tony yew Over a year ago

Where is my problem mate?

tony yew Over a year ago

can u take a look at Jai's answer below, he need not to clear the arr.

Sam Ternent · Accepted Answer · 2015-08-19 09:38:56Z

1

You're declaring your temp vars outside of your loops, these should be scoped to your loops and thrown away after each operation.

var arr = [],
    tempObj = {};

http://jsfiddle.net/samternent/rw0z9e2j/2/

answered Aug 19, 2015 at 9:38

Sam Ternent

2811 gold badge4 silver badges14 bronze badges

Comments

Jai · Accepted Answer · 2015-08-19 09:41:36Z

0

You have to put it after push:

arr.push(tempObj);
obj.players = arr;

Actually you need this:

var sports = [{
    "id": 1,
        "name": "baseball"
}, {
    "id": 2,
        "name": "Football"
}];

var playersData = [{
    "sport_id": 2,
        "id": "nv12",
        "name": "James"
}, {
    "sport_id": 2,
        "id": "nv11",
        "name": "Jean"
}];

var arr = [];

$.each(sports, function (i, obj) {
    $.each(playersData, function (i, player) {
        if (obj.id === player.sport_id) {
           var tempObj = {
                "sport_id": player.sport_id,
                    "id": player.id,
                    "name": player.name
            };
            arr.push(tempObj);
            obj.players = arr;
        }

    });
    
});

console.log(sports);

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

answered Aug 19, 2015 at 9:41

Jai

74.8k12 gold badges77 silver badges104 bronze badges

6 Comments

tony yew Over a year ago

this doesn't work, obj.players will refer to the playersData as it's in the $.each loop.

Jai Over a year ago

i have changed the arguments name for readability you can see first one in the each is obj and in second each is player instead of obj. so obj.players actually referring to the first one.

tony yew Over a year ago

can u help to take a look here? jsfiddle.net/2sn9vk2a it doesn't work, I tried to follow ur logic.

Jai Over a year ago

you can check your data if they have proper keys in it and i guess you need to ask to the person whose answer you have accepted.

tony yew Over a year ago

both of your code worked, but I don't know what's the different, and which one has better performaces.

|

vinodh · Accepted Answer · 2015-08-19 09:45:14Z

0

Hope you want to put inside the Sports group, but you are adding inside the player array, please notice, so please call

obj.sports = arr;

Hope it solve your problem .

answered Aug 19, 2015 at 9:45

vinodh

7341 gold badge7 silver badges20 bronze badges

Collectives™ on Stack Overflow

loop and put array within array according to id failed

4 Answers 4

2 Comments

Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related