JavaScript - for loop Iterations not working with indexOf function

Question

var text = "Uncle Bob was in World War II. Many people believe World War II was 
the most destructive war to date.";

var replace = text.indexOf("World War II");


for (var i = 0; i < text.length; i++) {
  if (replace[i] !== -1) {
    text = text.slice(0, replace) + "the second world war" +
      text.slice(replace + 12);
  }
  break;

}
alert(text);

Without the break command, this is an infinite loop. I cannot figure out how to replace both World War IIs in text. I understand indexOf only deals with the first instance, however, how can I iterate through text to make it deal with both/all instances of what I want to replace? Besides using string replace method.

Not sure this is what you're really looking for, but just in case: developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/… — Cypher
– Cypher, Commented Aug 20, 2015 at 5:53
indexOf() finds the first occurrence. It does not find all occurrences. — Paul
– Paul, Commented Aug 20, 2015 at 5:54
Use text = text.replace(/World War II/g, 'the second world war'); If you want to just replace the all occurrences of text. — Kalpesh Patel
– Kalpesh Patel, Commented Aug 20, 2015 at 5:54

napster · Accepted Answer · 2015-08-20 05:59:05Z

1

Use String replace() With a Regular Expression instead of for loop iteration.

var text = "Uncle Bob was in World War II. Many people believe World War II was the most destructive war to date.";
var str = text.replace(/World War II/g, 'the second world war');

answered Aug 20, 2015 at 5:59

napster

3691 gold badge5 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

BobRoss Over a year ago

Thank you very much! The book I'm reading talks about changing the first instance of "world war II" to "the second world war", then in the next loop iteration, finding the next surviving instances of "world war II" and changing that. I was trying to figure that out but I suppose it's not as efficient and more difficult.

Collectives™ on Stack Overflow

JavaScript - for loop Iterations not working with indexOf function

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related