how to debug this? Call to a member function result() on a non-object

Question

Please Help.. im using CODEIGNITER I want to print the value of my userlevel and email using echo.. to know if im getting the right data from the database.. then suddenly this error keep bugging me. beginner in CODEIGNITER need some help here.. thanks a lot!

in my controller:

if ($this->is_validated($rules))
{
        $where  = array('email' => $this->input->post('txt_email'));
        $data['query'] = $this->database_model->select_userlevel('userlevel', $where);
        $user = $data['query'];
        foreach($user->result() as $row)
        {
           echo $row->email;
           echo $row->userlevel;
        }
}

in my model:

public function select_userlevel($table, $where) 
{
    $this->db->where($where);
    $query =  $this->db->get($table);
    if ($query->num_rows() > 0) 
    {
        return true;
    }
    else
    {
        echo 'no value';
        return false;
    }
}

Saty · Accepted Answer · 2015-08-20 13:46:46Z

2

Instead of return true you need to return your query in model

Model

public function select_userlevel($table, $where) 
{
    $this->db->where($where);
    $query =  $this->db->get($table);
if ($query->num_rows() > 0) 
{
    return  $query;// return query here
}
else
{

    return false;
}

Controller

$user = $this->database_model->select_userlevel('userlevel', $where);
     foreach($user->result() as $row)
        {
       // your code here
      }

UPDATED FOR better solution and proper use of MVC.

Instead of return query you need to return data from your model

MODEL

public function select_userlevel($table, $where)
{
$this->db->where($where);
$query = $this->db->get($table);
if ($query->num_rows() > 0)
{
return $query->result(); // return your result
}
else
{

return false;
}
}

CONTROLLER

$user = $this->database_model->select_userlevel('userlevel', $where);
foreach ($user as $row) {
    // your code here
}

edited Aug 20, 2015 at 13:46

answered Aug 20, 2015 at 13:33

Saty

22.5k7 gold badges35 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

CodeGodie Over a year ago

agreed. The problem is that you are never returning the results to your controller.

Saty Over a year ago

@CodeGodie agree with you . This is bad use of MVC . I am only pointing the wrong thing in OP code

CodeGodie Over a year ago

hi @Saty, can you explain why this is bad use of MVC?

Saty Over a year ago

Fatching the result in controller is bad use .

CodeGodie Over a year ago

Gotcha. yes I agree. the controller should only receive the results.

Philip · Accepted Answer · 2015-08-20 13:46:43Z

0

$user is not an active record object, so it does not have a reference to the result method.

All of this logic belongs in the Model and not the Controller.

Controller

public function doSomething()
{
   if( !$this->is_validated($rules) ) 
       return;

   $email = $this->input->post('txt_email');

   $users = $this->database_model->select_userlevel($email);

   // for debugging
   var_dump( $users )
   die();
}

Model

public function select_userlevel($email)
{
    $query = $this->db->select()
                      ->where('email', $email)
                      ->get('userlevel');

    return ( $query->num_rows() > 0) ? $query->result() : false;
}

answered Aug 20, 2015 at 13:46

Philip

4,5822 gold badges22 silver badges28 bronze badges

2 Comments

CodeGodie Over a year ago

How is this different than @Saty 's answer?

Philip Over a year ago

It's not, he was just faster at typing the answer :)

Collectives™ on Stack Overflow

how to debug this? Call to a member function result() on a non-object

2 Answers 2

5 Comments

Controller

Model

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Controller

Model

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related