Java SQL exception command not properly ended

Question

help me with the below issue please. With the below code

 if (con == null || con.isClosed()) con = DBBase.getNewConnection();
    sb = con.createStatement();

    resSet = sb.executeQuery("select * from  USERSAGGRS  where userid='" +user.getUserid()+ "'  AND  id='" +aggid+ "'  ");

when load jsp page I get this error:

java.sql.SQLException: ORA-00933: SQL command not properly ended

show the total section of your code please.so as to get an outlook of your program — user4257136
– user4257136, Commented Aug 23, 2015 at 5:07

seenukarthi · Accepted Answer · 2015-08-23 05:22:22Z

1

Most likely the values of user.getUserid() and/or aggid are the problem. You can test it by printing the query and test that in any Oracle DBMS client.

System.out.println("select * from  USERSAGGRS  where userid='" +user.getUserid()+ "'  AND  id='" +aggid+ "'  ")

OTOH

The proper way to do is by using PreparedStatement

if (con == null || con.isClosed()) con = DBBase.getNewConnection();
    String SQL = "select * from  USERSAGGRS  where userid=?  AND  id=?"
    sb = con.prepareStatement(SQL);
    sb.setString(1,user.getUserid());
    sb.setString(2,aggid);
    resSet = sb.executeQuery();

By using PreparedStatement you can also avoid SQLInjections

edited Aug 23, 2015 at 5:22

answered Aug 23, 2015 at 5:11

seenukarthi

8,80310 gold badges51 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Java SQL exception command not properly ended

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related