PHP overloading a function from a parent class

Question

I have a thing which I thought should work, but it doesn't.

I have several Controller_## classes, they all extend from Controller_Core. Each Controller_##-class has a public function Save(). Now I figured that I want to perform some other general checking (addslashes for each $_POST-var) and thought if I add a public function Save() to the Controller_Core it would be executed by default because the ##-class extends from it. However, this is not the case.

My question; is it possible what I'm trying to achieve? Or am I mistaken by thinking this would ever work?

Borealid · Accepted Answer · 2010-07-10 07:28:49Z

5

Call parent::Save() in the subclass version of the method.

See http://php.net/manual/en/keyword.parent.php .

edited Jul 10, 2010 at 7:28

answered Jul 10, 2010 at 7:22

Borealid

99.4k9 gold badges112 silver badges124 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

user132014 Over a year ago

it doesn't have to be the first line, also '::'

jigfox Over a year ago

"first line of subclass" doesn't need to be the first, but must be with in the function and not the class

user132014 Over a year ago

@Jens: why the first line, can't we override a function and call parent at any point of its execution?

Ben Over a year ago

Hmm okay, I knew that was possible but I kinda thought PHP would look in all inherited classes for equal functioncalls and then execute them. But thanks for your answer, I'll add the line in all Controller_##-classes.

Borealid Over a year ago

Edited. It's just that the intuitive understanding is that the parent does something, and then the child extends on what the parent has done. So parent::Save() usually comes first.

|

JonG · Accepted Answer · 2010-07-10 11:29:17Z

1

Or you could apply refactoring to extract common behavior to your core class :

class Controller_Core {

    public function save() {
        if ( ! $this->_validateInfo() ) {

            return false;
        }

        return $this->_doSave();
    }

    protected function _validateInput() {
        //-- do stuff

        return true;
    }

    protected function _doSave() {
        //-- do stuff

        return true;
    }

}

You write the specific code in the children classes, as in :

class Controller_Extended extends Controller_Core {

    protected function _doSave() {

        //-- a new return
        return true;
    }
}

answered Jul 10, 2010 at 11:29

JonG

8591 gold badge6 silver badges10 bronze badges

Collectives™ on Stack Overflow

PHP overloading a function from a parent class

2 Answers 2

9 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related