iOS: update object of NSMutableArray in for loop

Question

I need to update / add a key -> value pair in a NSMutableArray.

I would like to add a key with a fix value if the key isn't set already.

I tried the following - but the app is crashing at addObject with a "mutating method sent to immutable object" error:

    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
    NSMutableArray *bookmarks = [defaults mutableArrayValueForKey:@"bookmarks"];

    for (id bookmark in bookmarks) {

        if ([bookmark objectForKey:@"type"] == NULL){
            [bookmark addObject:@"old" forKey:@"type"];
        }
    }

    [[NSUserDefaults standardUserDefaults] synchronize];

bookmarks is mutable but none of the arrays it contains are mutable. — rmaddy
– rmaddy, Commented Aug 25, 2015 at 0:09

rmaddy · Accepted Answer · 2015-08-25 00:35:52Z

1

Your outer array contains immutable dictionaries. One option would be the following:

NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
NSMutableArray *bookmarks = [defaults mutableArrayValueForKey:@"bookmarks"];

[booksmarks enumerateObjectsWithOptions:NSEnumerationConcurrent usingBlock:^(NSDictionary *bookmark, NSUInteger index, BOOL *stop) {
    if (!bookmark[@"type"]) {
        NSMutableDictionary *mutable = [bookmark mutableCopy];
        mutable[@"type"] = @"old";
        [bookmarks replaceObjectAtIndex:index withObject:[mutable copy]];
    }
}];

// Update NSUserDefaults
[[NSUserDefaults standardUserDefaults] setObject:bookmarks forKey:@"bookmarks"];

This should be nice an efficient since it can update multiple dictionaries concurrently.

answered Aug 25, 2015 at 0:35

rmaddy

320k44 gold badges548 silver badges591 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jacopo Penzo · Accepted Answer · 2015-08-25 00:37:59Z

0

Try this:

NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];

//SAVING

NSMutableArray *bookmarksSaving = [NSMutableArray new];

[bookmarksSaving addObject:[[NSMutableDictionary alloc] initWithObjects:@[@"red"] forKeys:@[@"color"]]];
[bookmarksSaving addObject:[[NSMutableDictionary alloc] initWithObjects:@[@"yellow"] forKeys:@[@"color"]]];
[bookmarksSaving addObject:[[NSMutableDictionary alloc] initWithObjects:@[@"green",@"new"] forKeys:@[@"color",@"type"]]];

[defaults setObject:bookmarksSaving forKey:@"bookmarks"];
[[NSUserDefaults standardUserDefaults] synchronize];

//MODIFY

NSMutableArray *bookmarks = [defaults mutableArrayValueForKey:@"bookmarks"];

NSUInteger index = 0;
for (NSDictionary *bookmark in bookmarks) {

    NSMutableDictionary *bookmarkMutable = [bookmark mutableCopy];

    if ([bookmarkMutable objectForKey:@"type"] == nil)
    {
        [bookmarkMutable setValue:@"old" forKey:@"type"];
        [bookmarks replaceObjectAtIndex:index withObject:bookmarkMutable];
    }

    index++;
}

[[NSUserDefaults standardUserDefaults] synchronize];

You have to save your bookmarks as NSMutableDictionary to be able to add/remove keys/value

edited Aug 25, 2015 at 0:37

answered Aug 25, 2015 at 0:20

Jacopo Penzo

2,1582 gold badges24 silver badges29 bronze badges

4 Comments

Laurenz Glück Over a year ago

my values are saved in a NSMutableDicionary: NSMutableDictionary *dict = [NSMutableDictionary dictionaryWithObjectsAndKeys:titel, @"titel", code, @"code", @"liga", @"type", nil]; [dataArray addObject:dict];

Rog Over a year ago

This is not going to work. Objects saved to user defaults are immutable so you need to make a mutableCopy of the dictionary. You are also modifying but not pushing it back to the array, and not pushing the modified array back to userDefaults so there's a lot missing there.

Laurenz Glück Over a year ago

@Rog okay, so the best way is to create a new NSMutableArray with the updated values and override the userDefaults?

Laurenz Glück Over a year ago

@JacopoPenzo I tried it already, but the app is crashing with this error: [__NSCFDictionary setObject:forKey:]: mutating method sent to immutable object

Rog · Accepted Answer · 2015-08-25 00:33:42Z

0

  NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
  NSArray *bookmarks = [defaults objectForKey:@"bookmarks"];
  NSMutableArray *newBookMarks = [bookmarks mutableCopy];
  for (NSDictionary *bookmark in bookmarks) {
    NSMutableDictionary *newBookmark = [bookmark mutableCopy];
    if (![bookmark objectForKey:@"type"]){
      [newBookmark setObject:@"old" forKey:@"type"];
    }
    [newBookMarks addObject:newBookmark];
  }
  [defaults setObject:newBookMarks forKey:@"bookmarks"];
  [defaults synchronize];

answered Aug 25, 2015 at 0:33

Rog

18.7k6 gold badges78 silver badges97 bronze badges

Collectives™ on Stack Overflow

iOS: update object of NSMutableArray in for loop

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related