Scala option variable overrides when string is not empty

Question

I have 2 option variables and want to assign 2nd one to 1st one when 1st is None or empty string. Is there a better way writing this? I need to do these for 10 other similar properties in a class.

var myoption1: Option[String]
var myoption2: Option[String]

import org.apache.commons.lang3.StringUtils
  implicit class Addons(val s: String) {
    def isEmptyS = StringUtils.isEmpty(s)
    def isNotEmpty = StringUtils.isNotEmpty(s)
  }

if (myoption1.map(_.isEmpty).getOrElse(true) &&
    myoption2.map(_.isNotEmpty).getOrElse(false)
    ) myoption1 = myoption2

Tyth · Accepted Answer · 2015-08-25 17:22:01Z

3

If you don't care which empty string out of 2 will end up in myoption1 if both of them are empty, then I suggest this:

myoption1 = myoption1.filter(_.nonEmpty).orElse(myoption2)

edited Aug 25, 2015 at 17:22

answered Aug 25, 2015 at 16:19

Tyth

1,8241 gold badge12 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Tyth Over a year ago

I know, just thought that StringUtils.isEmpty could contain different logic regarding trimming or whatever. Edited.

Victor Moroz Over a year ago

shouldn't it be filterNot?

angelokh Over a year ago

@VictorMoroz The question is to assign 2nd one to 1st one when 1st is None or empty string.

Victor Moroz Over a year ago

@angelokh it was myoption1.filter(_.isEmpty) at the time I asked

Collectives™ on Stack Overflow

Scala option variable overrides when string is not empty

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related