Error while initializing the structure values

Question

I have just started using pointers.So please bear with me if this looks silly But I am not able to find the reason. I have a structure

typedef struct Intermediatenode
{
    int key;
    char *value;
    int height;
    struct node *next[SKIPLIST_MAX_HEIGHT];
} node;

And I wand to create a new node by using below function

 node *create_node(int key, char * val, int h)
 {
        node *newnode;
        newnode=malloc(sizeof(node));
        newnode->height=h;
        newnode->key=key;
        printf("till here %s \n",val);
        printf("till here %d \n",newnode->height);
        printf("till here %d \n",newnode->key);
        strcpy(newnode->value,val);
        printf("till here %s \n",newnode->value);
        return newnode;
 }

But I Am getting segmentation fault at this "strcpy(newnode->value,val);" Can you please help me with that.Thanks a lot

paddy · Accepted Answer · 2015-08-30 23:50:00Z

4

You allocated memory for the node, but not the string in value. The strcpy function will copy bytes but not allocate memory. It assumes that you've already arranged that. In a pinch, you can allocate and copy the string with strdup:

newnode->value = strdup(val);

answered Aug 30, 2015 at 23:50

paddy

63.7k7 gold badges68 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

paddy Over a year ago

Note that when you free your node later, you'll need to first free that value.

Collectives™ on Stack Overflow

Error while initializing the structure values

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related