How can I check if a row is empty in mySQL using PDO?

Question

This is how I would normally check for empty results: mysql_fetch_assoc

However, I am using PDO for a client and in this login function, I want to return some text or a number or boolean to say a row was found or not.

public function Login ($email,$password)
{
  $sqlQuery="SELECT * FROM db_user WHERE email= '".$email."'  AND password='".$password." '";
  $statement = $this->_dbHandle->prepare($sqlQuery); // prepare a PDO statement
  $statement -> execute();

  $dataSet= [];
  if(mysql_num_rows($statement) == 1){
    echo 'login true';
  } else {
    echo 'login false';
  }

use$count = $statement->num_rows; instead mysql_num_rows — Saty
– Saty, Commented Sep 4, 2015 at 6:37
Try using a COUNT(*) statement instead. You can't use both PDO and mysql at the same time. Well you could but it would be silly...and also not in the way you are trying. — Rasclatt
– Rasclatt, Commented Sep 4, 2015 at 6:42
mysql_num_rows isn't PDO. You can't mix APIs like that. It should be $statement->numRows(). — Barmar
– Barmar, Commented Sep 4, 2015 at 7:05

Your Common Sense · Accepted Answer · 2015-09-04 07:39:03Z

2

Both other answers are essentially unacceptable.
And not because they lack cleanness but because they are awfully dangerous

public function Login ($email,$password)
{
  $sql="SELECT 1 FROM db_user WHERE email=?  AND password=?";
  $stmt = $this->_dbHandle->prepare($sql);
  $statement -> execute([$email, $password]);
  return $stmt->fetchColumn();
}

You should be using prepared statements, not just mimicking them.

edited Sep 4, 2015 at 7:39

answered Sep 4, 2015 at 7:24

Your Common Sense

158k42 gold badges226 silver badges374 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

6339 Over a year ago

on line '$statement -> execute($email, $password);' the 'execute' method expecting an array rather than string. It'll should be like '$statement -> execute(array($email, $password));'

TheBlackBenzKid Over a year ago

Not seen @Your Common Sense in a long time... though you were banned

Omkar · Accepted Answer · 2015-09-04 06:44:31Z

0

  $sqlQuery="SELECT * FROM db_user WHERE email= '".$email."'  AND password='".$password." '";
  $statement = $this->_dbHandle->prepare($sqlQuery); // prepare a PDO statement
  $statement -> execute();
  $rows = $statement ->fetch(PDO::FETCH_ASSOC);

  if( ! $rows)
  {
    die('Empty Records');
  }

answered Sep 4, 2015 at 6:44

Omkar

3085 silver badges27 bronze badges

1 Comment

TheBlackBenzKid Over a year ago

This looks really clean.

6339 · Accepted Answer · 2015-09-04 08:15:02Z

0

  $sqlQuery= "SELECT * FROM db_user WHERE email= ? AND password= ?";
  $statement = $this->_dbHandle->prepare($sqlQuery); // prepare a PDO

  // pass parameter to tackle [SQL Injection][1]
  $stmt->execute(array($email, $password)); 

  $result = $stmt->fetch();
  if( $result ) {
      echo "login true";
  }else{
      echo "login false";
  }

edited Sep 4, 2015 at 8:15

answered Sep 4, 2015 at 7:23

6339

4753 silver badges16 bronze badges

2 Comments

Your Common Sense Over a year ago

Do not use try catch for error reporting

6339 Over a year ago

@YourCommonSense I never know that. Editing my answer.

Collectives™ on Stack Overflow

How can I check if a row is empty in mySQL using PDO?

3 Answers 3

2 Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related