Creating objects from text file input

Question

I'm still very new to java. I am trying to create an array of objects from a text file. The text file has a list of names, and using these names, I'm trying to create objects. This is the method I've created to create the objects from the text file input. It gives an error when compiled. I'm not sure where I've done wrong.

   public boolean createObjects(PersonNames2[] person) throws Exception
   {
       boolean found = false;
       int position = 0;
       if(canCreateObjects() == true)
       {
           for(int i = 0; i < persons.length && !found; i++)
           {
               if(persons[i] == null)
               {
                   position = i;
                   found = true;
               }
           }
           Scanner reader = new Scanner(file);
           while(reader.hasNext())
           {
               person[position] = new PersonNames2();
               position++;
           }
           reader.close();
           return true;
       }
       return false;
   }

I get this error PersonNames2.java:27: error: array dimension missing PersonNames person[] = new Person[]; ^ 1 error — Michelle Ashwini
– Michelle Ashwini, Commented Sep 14, 2015 at 7:13
@sᴜʀᴇsʜᴀᴛᴛᴀ Lol....welcome back....have not seen u here for sometime...im also not so active:p — Juned Ahsan
– Juned Ahsan, Commented Sep 14, 2015 at 7:13

Suresh Atta · Accepted Answer · 2015-09-14 07:22:53Z

2

error: array dimension missing PersonNames person[] = new Person[];

That's clearly telling that you are failed to give the size of your array.

You need to write

PersonNames person[] = new Person[size]; // For ex : 10 or any X

Array's are fixed in size and you need to tell the size of it while declaring/initializing it self.

Update:

Since you are reading data from a file and no idea about the length of array, better to choose ArrayList instead of array. Size of the ArrayList increases over the time you add elements to it.

edited Sep 14, 2015 at 7:22

answered Sep 14, 2015 at 7:14

Suresh Atta

122k38 gold badges206 silver badges315 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Michelle Ashwini Over a year ago

If I were to create a an array with a set size i would just PersonNames person = new Person[5]. How can I go about doing this if I'm using the no of lines in the file as the size

Suresh Atta Over a year ago

@MichelleAshwini Updated my answer :) Hope that helps

Michelle Ashwini Over a year ago

@SURESHATTA That makes sense. I'm trying that out now. Will get back on it.

Haider Ali Over a year ago

I thought you were passing array as argument in function boolean createObjects(PersonNames2[] person) so why need to initialize ???

Karol Król · Accepted Answer · 2015-09-14 07:55:42Z

0

If you are new in Java, than this tiny GitHub project could be a nice set of hints for you.

answered Sep 14, 2015 at 7:55

Karol Król

3,5601 gold badge37 silver badges38 bronze badges

Comments

Michelle Ashwini · Accepted Answer · 2015-09-15 04:03:15Z

0

I've managed to get this working. Thanks! Here is the working code.

    public static List<Person> loadPersons(String path) throws Exception
    {
        BufferedReader reader = new BufferedReader(new FileReader(path));
        List<Person> persons = new ArrayList<Person>();

        while((line = reader.readLine()) != null)
        {
            System.out.println("Adding " +line);
            persons.add(new Person(line));
        }

        return persons; 
    }

answered Sep 15, 2015 at 4:03

Michelle Ashwini

8985 gold badges14 silver badges28 bronze badges

Collectives™ on Stack Overflow

Creating objects from text file input

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related