Php redirect to page if statement

Question

I'm trying to make you redirect to the successful page after succesfully registering but whenever I click the register button I get redirected instantly even if all the input's are empty

if(isset($_POST["registration"])){
    if(!empty($_POST["gender"])
    and !empty($_POST["username"])
    and !strlen($_POST["username"]) < 3
    and !empty($_POST["email"])
    and !email($_POST["email"])
    and !empty($_POST["emailver"])
    and !verification($_POST["email"],$_POST["emailver"])
    and !empty($_POST["password"])
    and !strlen($_POST["password"]) < 8
    and strlen($_POST["password"]) < 25
    and checkUppercase($_POST["password"])
    and checkLowercase($_POST["password"])
    and checkNumber($_POST["password"])
    and !empty($_POST["passwordver"])
    and !verification($_POST["password"],$_POST["passwordver"])){
        if(addgamer($db,$_SESSION["gender"],$_SESSION["username"],$_SESSION["email"],$_POST["password"]) === TRUE){
            $url = 'succesfull.html';
            header($url);
        }
    }
}

The function for addgamers

function addgamer($db,$gender,$username,$email,$password){

    $sql = "INSERT INTO gamers (`gender`, `username`, `email`, `password`) VALUES('$gender','$username','$email','$password')";
    $db -> exec($sql);
    if ($db->query($sql) === TRUE) {
        $GamerId = $db -> lastInsertId();
        $_SESSION['GamerId'] = $GamerId;
        return true;
    } else {
        return false;
    }
}

I found some answers here but all of them do the same and I have no solution for this.

GOTO($url);

Or

header('location: $url');

Or

if(addgamer($db,$_SESSION["gender"],$_SESSION["username"],$_SESSION["email"],$_SESSION["password"]) === FALSE ){
    die();
}else{
    $url = 'successful.php';
    header($url);
}

Also tried with jQuery

echo "<script>window.location = '$url'</script>";

On every single click on the registration submit button you get redirected to the successful page but that should not happen until everything is filled in correctly as shown from the above code.

As you can also see I'd like to fix this problem trying with php only first.

What does addgamer() do? Also, if you're using header() for redirecting, it's used like header("Location: path.html");. — Qirel
– Qirel, Commented Sep 14, 2015 at 16:16
Are you sure you aren't unintentionally redirecting from somewhere else? Delete your redirect and just add a print statement to make sure — samrap
– samrap, Commented Sep 14, 2015 at 16:16
First couple of points header() should look like this header('Location: xxx.php); and should be followed by an exit; to stop execution at that point. — RiggsFolly
– RiggsFolly, Commented Sep 14, 2015 at 16:18
Please show your <form tag and tell us the name of this form you have shown us. My gues is you are completely confused, as are we — RiggsFolly
– RiggsFolly, Commented Sep 14, 2015 at 16:20
The beginning for my form is: '<form name="registration" action="successful.php" method="post">' — Wanjia
– Wanjia, Commented Sep 14, 2015 at 16:25

Matthijs van Hest · Accepted Answer · 2015-09-14 16:25:00Z

2

Validate before submitting the form would be better at first. As @Nicolas D mentioned you should also know that the form action is the page you direct to no matter what.

You can however set this to the current page by using action="" or action="<?php echo $_SERVER['PHP_SELF']; ?>"

This last could come with exploits, you can use "htmlentities($_SERVER['PHP_SELF'])" instead. Read about this here.

answered Sep 14, 2015 at 16:25

Matthijs van Hest

7891 gold badge6 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Wanjia Over a year ago

I have tried to use the 'action="<?php echo $_SERVER['PHP_SELF']; ?>"' and seems to work.

Matthijs van Hest Over a year ago

@Wanjia , don't forget to rewrite your header(); which should be used like: header('Location: xxx.php'); and BEFORE any HTML.

Wanjia Over a year ago

As this seems to help the problem I had it created a new one. It might be me looking over the badly coded problem but it adds the gamer but does the else statement instead of redirecting.

Nicolas D Over a year ago

@Wanjia look at my solution then, it won't be the easiest but it might be the best thing you can do and learn to improve your coding skills :)

Wanjia Over a year ago

I will but when I chanced "$db->query($sql) === TRUE" to "$db->query($sql)" it all seems to work and I don't know how.

|

Nicolas D · Accepted Answer · 2015-09-14 16:18:53Z

2

You have a missunderstanding PHP problem. If your form use a submit form, it will post automatically to the php page targeted. If you don't want to post to a new page and still verify your data, then you must use ajax in jquery : http://api.jquery.com/jquery.post/ . With that you ll catch your data without unexpected redirection. Once all your form is validated by your php code during ajax call, you can redirect in jquery on the callback function.

Hope this will help, I ve been through this step and I remember it was painful

answered Sep 14, 2015 at 16:18

Nicolas D

1,22220 silver badges43 bronze badges

Collectives™ on Stack Overflow

Php redirect to page if statement

2 Answers 2

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related