Button in view not clicking ios swift

Question

I'm trying to implement a dropdown menu in Swift by adding a view below the navigation bar and initially setting it to hidden until a navigationBarItem button is pressed, which works. In the dropdown View I have added two buttons as seen in the code below but it doesn't seem to pick up the event.

var isAnimating: Bool = false
var dropDownViewIsDisplayed : Bool = false
var dropDownView : UIView!

var buttonOne : UIButton!
var buttonTwo : UIButton!

var screenWidth : CGFloat!

@IBOutlet weak var searchNavigationBar: UINavigationItem!

override func viewDidLoad() {
    super.viewDidLoad()

    screenWidth = self.view.bounds.size.width
    self.navigationController?.navigationBar.translucent = false
    dropDownView =  UIView(frame: CGRectMake(0, -15, screenWidth, -80))

    dropDownView.hidden = true
    dropDownView.userInteractionEnabled = true
    self.navigationController?.view.insertSubview(self.dropDownView, belowSubview: (self.navigationController?.navigationBar)!)

    buttonOne = UIButton(frame: CGRectMake(0, 0, screenWidth, 40))
    buttonOne.setTitle("Button One", forState: .Normal)
    buttonOne.setTitleColor(UIColor.blackColor(), forState: .Normal)
    buttonOne.backgroundColor = UIColor.whiteColor()
    buttonOne.addTarget(self, action: Selector("buttonOnePressed"), forControlEvents: UIControlEvents.TouchUpInside)
    buttonOne.userInteractionEnabled = true
    dropDownView.addSubview(buttonOne)

    buttonTwo = UIButton(frame: CGRectMake(0, buttonOne.bounds.size.height, screenWidth, 40))
    buttonTwo.setTitle("Button Two", forState: .Normal)
    buttonTwo.setTitleColor(UIColor.blackColor(), forState: .Normal)
    buttonTwo.backgroundColor = UIColor.whiteColor()
    buttonTwo.addTarget(self, action: Selector("buttonTwoPressed"), forControlEvents: UIControlEvents.TouchUpInside)
    buttonTwo.userInteractionEnabled = true
    dropDownView.addSubview(buttonTwo)

}

func buttonTwoPressed(){
    self.performSegueWithIdentifier("showLocation", sender: self)
}

override func prepareForSegue(segue: UIStoryboardSegue, sender: AnyObject?) {
    if (segue.identifier == "showLocation") {
        var location: LocationTableViewController = (segue.destinationViewController as? LocationTableViewController)!

    }
}

Button click functions are not being called.

Please ensure that you do not have some transparent view on top of UIButton and that action button is not implemented as buttonOnePressed: — Abhinav
– Abhinav, Commented Sep 24, 2015 at 14:13
do you have a visual feedback when you press on the buttons? — bsarr007
– bsarr007, Commented Sep 24, 2015 at 14:24
not at the moment, only using breakpoints and the debugger but the functions aren't being called. — DrPatience
– DrPatience, Commented Sep 24, 2015 at 14:25

Ducky · Accepted Answer · 2015-09-24 14:27:35Z

1

Are you using Swift 2.0 with Xcode 7? Just by quickly tried playing with your code like this, I found that the event handlers are being called properly without any big changes. Are you sure that there is nothing wrong somewhere else?

var isAnimating: Bool = false
var dropDownViewIsDisplayed : Bool = false
var dropDownView : UIView!

var buttonOne : UIButton!
var buttonTwo : UIButton!

var screenWidth : CGFloat!

@IBOutlet weak var searchNavigationBar: UINavigationItem!

override func viewDidLoad() {
    super.viewDidLoad()

    screenWidth = self.view.bounds.size.width
    self.navigationController?.navigationBar.translucent = false

   // I modified these 2 lines to test your code immediately
    dropDownView =  UIView(frame: CGRectMake(0, 65, screenWidth, 80))        
    dropDownView.hidden = false

    dropDownView.userInteractionEnabled = true
    self.navigationController?.view.insertSubview(self.dropDownView, belowSubview: (self.navigationController?.navigationBar)!)

    buttonOne = UIButton(frame: CGRectMake(0, 0, screenWidth, 40))
    buttonOne.setTitle("Button One", forState: .Normal)
    buttonOne.setTitleColor(UIColor.blackColor(), forState: .Normal)
    buttonOne.backgroundColor = UIColor.whiteColor()
    buttonOne.addTarget(self, action: Selector("buttonOnePressed"), forControlEvents: UIControlEvents.TouchUpInside)
    buttonOne.userInteractionEnabled = true
    dropDownView.addSubview(buttonOne)

    buttonTwo = UIButton(frame: CGRectMake(0, buttonOne.bounds.size.height, screenWidth, 40))
    buttonTwo.setTitle("Button Two", forState: .Normal)
    buttonTwo.setTitleColor(UIColor.blackColor(), forState: .Normal)
    buttonTwo.backgroundColor = UIColor.whiteColor()
    // Here I just wanted to show you that calling Selector() is not necessary at all
    buttonTwo.addTarget(self, action: "buttonTwoPressed", forControlEvents: UIControlEvents.TouchUpInside)
    buttonTwo.userInteractionEnabled = true
    dropDownView.addSubview(buttonTwo)
}

// I didn't see this method in your code above so I added to test and it works!
func buttonOnePressed() {
    print("buttonOnePressed")
}
// This is also being called normally
func buttonTwoPressed() {
    print("buttonTwoPressed")
}

answered Sep 24, 2015 at 14:27

Ducky

2,75419 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

DrPatience Over a year ago

very odd it doesn't work on mine. Perhaps because the controller is a root controller of a navigation controller in the main story board ?

Ducky Over a year ago

My view controller is also the root view controller of a navigation controller so it must not be the point. Could you share your code via GitHub?

DrPatience Over a year ago

hey thanks, I've sorted it out now. Had to do with the initial frame it was set to. Thanks for your pointers

Abhinav · Accepted Answer · 2015-09-24 14:15:04Z

0

Can you please try with:

buttonOne.addTarget(self, action: Selector("buttonOnePressed:"), forControlEvents: UIControlEvents.TouchUpInside)

buttonTwo.addTarget(self, action: Selector("buttonTwoPressed:"), forControlEvents: UIControlEvents.TouchUpInside)

answered Sep 24, 2015 at 14:15

Abhinav

38.2k43 gold badges196 silver badges314 bronze badges

2 Comments

Abhinav Over a year ago

After you shared your button handler code, I see you have implemented it correctly. Did u check if there is some transparent view covering buttons?

DrPatience Over a year ago

how do you check for that ? this controller is a root view controller of a navigation controller in the story board.

ChikabuZ · Accepted Answer · 2015-09-24 14:44:25Z

0

It won't works because it outside self.navigationController?.navigationBar.frame. You should add buttons on self.view or transparent modal view/UIWindow.

edited Sep 24, 2015 at 14:44

answered Sep 24, 2015 at 14:32

ChikabuZ

10.2k5 gold badges68 silver badges90 bronze badges

Collectives™ on Stack Overflow

Button in view not clicking ios swift

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related