109

I'd like to add an automatically generated file to the same commit using a pre- or post-commit hook in Git, dependent on the files that were modified in that commit. How would I go about this?

I've tried this as a pre-commit hook, but no luck:

#!/bin/sh
files=`git diff --cached --name-status`
re="<files of importance>"
if [[ $files =~ $re ]]
then
  echo "Creating files"
  exec bundle exec create_my_files
  exec git add my_files
  exec git commit --amend -C HEAD
fi

This successfully adds them to the repository, but does not add them to the commit. I've also tried using the last two exec lines in a post-commit hook along with the pre-commit inspection, but no good either.

2
  • 5
    You need to remove the execs from this code (see man sh). It's impossible for any shell command to be executed after an exec, since exec clobbers the current process, i.e. the shell that is used to interpret commands. Commented Mar 19, 2018 at 20:15
  • Even if this is possible through various hacks, I'd argue the most correct answer is the one given in stackoverflow.com/a/73674325/3412775 - namely, that pre-commit hooks aren't meant for modifying code, and this would be better achieved through a standalone script that wraps the whole commit process. Commented May 20 at 19:10

11 Answers 11

80

Since git add was also not working for me in a pre commit, I followed mark's idea of using a .commit file and splitting the process into pre- and post-commit.

Here is some code that should be easy to understand

In the pre-commit:

  • Touch a file .commit or something. (be sure to add this to .gitignore)
#!/bin/sh 
echo 
touch .commit 
exit

In the post-commit:

if .commit exists you know a commit has just taken place but a post-commit hasn't run yet. So, you can do your code generation here. Additionally, test for .commit and if it exists:

  • add the files
  • commit --amend -C HEAD --no-verify (avoid looping)
  • delete .commit file
#!/bin/sh
echo
if [ -e .commit ]
    then
    rm .commit
    git add yourfile
    git commit --amend -C HEAD --no-verify
fi
exit

Hope this makes it easier for people with few bash knowledge to follow mark's idea.

Sign up to request clarification or add additional context in comments.

9 Comments

Shouldn't -a be -e to test if .commit exist?
@AlbertNetymk - there is practically no difference; the -a primary was introduced as a KornShell proposal and made its way to POSIX, it's only supported today for backwards-compatibility. later -e was added to avoid confusing the -a primary with the -a binary operator.
@EliranMalka Could you provide a ref? I have trouble locating -a. linux.die.net/man/1/test The only use I found is for logical and.
@jcollum: Apparently, the .commit file prevents an infinite loop. Specifically, --no-verify doesn't prevent the post-commit hook from running, so the post-commit runs twice: once when the .commit file is present, which then runs git commit --amend … which triggers the post-commit hook again, but this time with the .commit file being gone, which ends the loop.
This scheme works for me, with the critical modification that I had to move the git add to the pre-commit hook instead of the post-commit hook. I'm using git version 2.25.1 on macOS.
|
40

It's possible to do what you want using pre-commit hooks. We do something similar for a heroku deployment (compiling coffeescript to javascript). The reason your script isn't working is because you used the exec command improperly.

From the man page:

The exec builtin is used to replace the currently running shells process image with a new command. On successful completion, exec never returns. exec can not be used inside a pipeline.

Only your first exec command is running. After that your script is basically terminated.

Give something like this a try (as a pre-commit hook):

#!/bin/sh
files=`git diff --cached --name-status`
re="<files of importance>"
if [[ $files =~ $re ]]
then
  echo "Creating files"
  bundle exec create_my_files
  git add my_files
fi

10 Comments

This is not working in recent git (I use 1.7.9), git add in pre-commit adds the files for future commit, not the one you just engaged.
Works for me in git 1.7.10. The files are not added to the commit message, but they are commited. It seems that the 'git status' in the commit message is generated before pre-commit. This seems like a bug to me, but I suspect it was done on purpose for some reason. What you can do is add a line to the end of pre-commit that looks something like 'git status; echo -n Hit enter to continue...; read'. There is likely a better way to solve this, but that was a quick fix for me.
I have git 1.8.3.4 and whatever is added in pre-commit hook doesn't appear to be staged until the next commit.
Actually, I can confirm this works in git 2.7.4 I'm using right now. It doesn't appear that way when editing the commit message, but when you actually commit you will see the files you added during the pre-commit hook appear in the commit.
Not work in 2.11.0 either. Changes are added but not committed.
|
18
#!/bin/sh
#
#  .git/hooks/pre-commit
#

git add file.xyz

This worked just fine for me. It will be part of the current commit.

git version 1.7.12.4 (Apple Git-37)

3 Comments

This worked for me, too, except I needed to change the working directory of my script using cd $(git rev-parse --show-toplevel)
Worked for me too. If doing just git commit, the added files won't appear in the automatically generated commit message, but they will be added anyway.
This seems to contradict this. And is actually my problem. The add is done but the file is not commited.
14

You could use a combination of a pre and post commit script.

In the pre-commit:

  • Touch a file .commit or something. (be sure to add this to .gitignore)

In the post-commit:

if .commit exists you know a commit has just taken place but a post-commit hasn't run yet. So, you can do your code generation here. Additionally, test for .commit and if it exists:

  • add the files
  • commit --amend -C HEAD --no-verify (avoid looping)
  • delete .commit file

This is roughly the process I use to store a .metadata file in the repository generated from metastore.

If anyone knows a better way I'm all ears but it seems to work for now.

Comments

12

You can use update-index:

git update-index --add my_files

6 Comments

I updated the question with the information. There are no errors. The files are created. Git status shows they've been added but not committed.
It's possible that another option to update-index will be what you need, too: ftp.sunet.se/pub/Linux/kernel.org/software/scm/git/docs/…
I will definitely look at that as an option. Thanks!
I don't know about @IanTerrell, but I'm still stuck on this. I tried both git add and git update-index --add. In both cases the files get added to the repository (so they'd be in the next commit), but not to the current commit.
rfunduk's response worked perfectly for me on git 2.6.2, i.e. git update-index --add my_files
|
3

How about writing a post-commit script instead which generates your files, and then have that do (something along the lines of) git add my_files; git commit --amend.

3 Comments

git-scm.com/docs/githooks post-commit runs after the commit is complete -- you can't amend it at that point afaics
git commit --amend changes the previous commit (which as you said has just happened)
Won't running the commit end up in an infinite loop of commit+post-commit?
1

I had the same need and this approach worked pretty well for me:

#!/bin/sh
files='git diff --cached --name-only'
re="<files of importance>"
if [[ $files =~ $re ]]
then
   echo "Creating files"
   create_my_files && git add my_files
fi

where "create_my_files" should be executable, for example if it is a python file you could execute it as "python create_my_files && git add my_files"

and is true you don't need a pre-commit to commit again (that would create a infinite nasty loop :p)

1 Comment

git add in a pre-commit hook doesn't work as intended for me in Git 2.6.4
0

If the files are automatically generated, and they can be generated anywhere (implicit in your desire to build them in the Git pre-commit hook) then you shouldn't be putting them under source control in the first place. You should only control source files -- generated files should be generated as part of the build scripts.

The only reason to put a generated file under source control is when it requires unique/privileged resources to generate (such as a licensed program) or it requires a significant amount of time to generate.

Added

From http://git-scm.com/docs/githooks :

pre-commit This hook is invoked by git commit, and can be bypassed with --no-verify option. It takes no parameter, and is invoked before obtaining the proposed commit log message and making a commit. Exiting with non-zero status from this script causes the git commit to abort.

The default pre-commit hook, when enabled, catches introduction of lines with trailing whitespaces and aborts the commit when such a line is found.

All the git commit hooks are invoked with the environment variable GIT_EDITOR=: if the command will not bring up an editor to modify the commit message.

The intent of the pre-commit hook is to be a pass-fail check on the state of the workspace and the contents of the commit, prior to making the commit. Attempting to change the contents of the commit won't work.

My recommendation would be add two steps to your build scripts: (1) a step that will build all of the out-of-date files that needs to be generated (and adds them to the workspace), and (2) a step that will check to ensure that all of the generated files are up-to-date, and return a non-zero status code. Your Git pre-commit hook should run the second step. Your developers should be trained to run the first step as necessary.

6 Comments

True, but doesn't answer the question. He might have a very good reason for putting the generated file under source control, that's not for us to decide :)
They can't be generated anywhere: they're being deployed from source control to a read-only filesystem.
There you have it! :) You might try to put the generation step into your deploy script, but that might also be impractical.
The deployment is automated with a git push (it's a Rails app on Heroku), so it's not terribly practical to put it there. Pre-commit is really the place for it, as I can test to see if any dependent files have changed and only rebuild the generated files if they have.
@Ian, it really sounds like this is something for your build scripts, before you commit, instead of trying to use Git to automate the generation. If anything should be put into the pre-commit step, it should be a check to ensure that the files are up-to-date before committing (and fail the commit if they are out of sync).
|
0

Yes, you can add generated files automatically on the commit using git hooks! But it requires a tricky script.

Here you can find the problem solved. There, it is updating the file version on every commit, adding a new modified file and amending the commit as you need it to. It is fully working: https://github.com/evandrocoan/.versioning

Then you just replace the 'Version File Replacement' algorithm on the file 'updateVersion.sh', by your algorithm. Maybe you need to change a few things like, remove the branch limitation, because there, the script only runs if you are on the 'develop' branch.

Also, it will only change the specified file, if is staged. If the file is not staged, then it will do nothing than the normal/usual commit. More precisely, it print out what it is doing on every step.

I am going to explain, that trick. It is quite tricky. On the prepare-commit-msg-hook, it detects whether the desired file is being staged and committed. After that, it creates a flag file, and stops the prepare-commit-msg-hook. Later on the post-commit-hook, it checks whether the flag file exists. If yes, it amends the files on the commit.

Attention, it would create a infinity loop because it would call again the prepare-commit-msg-hook (as we are amending). But it does not happen because of the flag file. When the prepare-commit-msg-hook runs and find the flag file, it "knows" what is happening. Then is just deletes the flag file and do not create it again. Doing it, it will block the post-commit-hook from amending again the commits, allowing the commit to finish for good.

Comments

0

Imagine you have a pre-commit hook that does this:

#!/bin/bash

echo "--- Dataset Pre-Commit Hook ---"

DATASET_REPO_PATH="$(pwd)"

python3 -m my_script_that_generates_or_modifies_a_file
git -C $DATASET_REPO_PATH add file

echo "--- Done ---"
exit

It will work IF AND ONLY IF, there was already something to be commited. It does not have to be the same file tho. If there was nothing to be commited, the git add git add file will work, but will not be commited.

Example that works:

  1. You changed a file, and added it (for example, the gitignore)
$> git status
On branch master

No commits yet

Changes to be committed:
  (use "git rm --cached <file>..." to unstage)
        new file:   .gitignore
  1. Run commit. First, the pre-commit hook will run and create file. Then it will commit.
--- Dataset Pre-Commit Hook ---
--- Done ---
[master (root-commit) 2ba2f7c] First commit
 3 files changed, 34 insertions(+)
 create mode 100644 .gitignore
 create mode 100644 file
  1. You can see the message says file was commited. And git status now outputs:
On branch master
nothing to commit, working tree clean

Example that DOES NOT work

  1. You have nothing to add. You can of course run git add but it will do nothing. git status gives:
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
  1. Run commit. The hook will create file. But the commit message says he did nothing.
--- Dataset Pre-Commit Hook ---
--- Done ---
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
  1. Verify the status git status
On branch master
Your branch is up to date with 'origin/master'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        modified:   file
  1. You can see that file was indeed modified, and that it was added, but yet not commited. You need to run git commit again for it to work.

I tried adding that as a post-commit hook but got no luck. If someone knows a fix for this case, I would love to know.

Comments

-2

I was facing same problem in pre-commit hook also. I was modifying one file and committing but it was taking previous file not updated file so by adding git command(as below) in pre-commit hook, it solved.

git add $file

note: $file is your file to be added.

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.