Int variable showing wrong value - Android

Question

This code gives me wrong output, im not sure why, and I am going crazy.

    float correctX=((getWidth()/599)*x);
    float correctY=((getHeight()/740)*y);

The result I get is: x = 520 y = 900.

And logcat output log: DETAILS----------Width: 1080. Heigth: 1533. X Value: 520. Y Value: 450

Why ? I have no clue and Im going crazy, i dont even know if its the correct syntax anymore lol.

I use android studio btw

Michael · Accepted Answer · 2015-10-03 17:10:44Z

2

This is because of integer division (go to Confusing Divisions) inaccuracies. Cast a few values to floats to make it better.

 int correctX = (int)((1080f/599)*520);

OR

Just change correctX to a float

 float correctX = (1080f/599)*520;

answered Oct 3, 2015 at 17:10

Michael

2,8111 gold badge19 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Jozo Over a year ago

Still incorrect. This is how I write it: float correctX=((getWidth()/599)*x); float correctY=((getHeight()/740)*y); This is the logcat output I get: DETAILS----------Width: 1080. Heigth: 1533. X Value: 520. Y Value: 450

Michael Over a year ago

That's because there are still no floats on the right hand of your assignment. It should be: ` float correctX=((getWidth()/599f)*x)` @JozefM

Jozo Over a year ago

What does float s actually mean ?

Jozo Over a year ago

What the hell, it works! Lol thanks alot!!! Unsure what it means tho, some googling tells me it tells the system it should be a 32bit variable, but not sure why that makes a diffrence

Michael Over a year ago

Take a look at these: java.about.com/od/f/g/float.htm ---- dummies.com/how-to/content/… @JozefM

|

Collectives™ on Stack Overflow

Int variable showing wrong value - Android

1 Answer 1

OR

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

OR

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related