getting service instance in controller

Question

I'm trying to get a service instance but am getting an error. I am getting the exception that Calculator.random() is not a function. Any idea what I'm doing wrong?

angular
    .module('app')
    .factory('Calculator',function(){
        var random = {};
        random.number = function (){
            return Math.random();
        };
        return random;
    });

angular
    .module('app')
    .controller('homeCtrl', ['$scope','Calculator', function ($scope,Calculator) {

        $scope.random = Calculator.random();

    }]);

Cyril Cherian · Accepted Answer · 2015-10-04 01:09:55Z

2

You can try like this:

angular
.module('app').controller('homeCtrl', function($scope, Calculator) {
$scope.random=Calculator.number();//in your factory number holds the random function.
}

IN your case its breaking reason: Calculator.random(); is not a function.

answered Oct 4, 2015 at 1:09

Cyril Cherian

32.4k7 gold badges48 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

shaunhusain · Accepted Answer · 2015-10-04 02:33:55Z

Like Cyril said, you define an object with a local name random in the calculator factory definition. You then return that object but that object has a property called number that points to a function not a property called random.

angular
    .module('app', [])
    .factory('Calculator',function(){
        var random = {};
        random.number = function (){
            return Math.random();
        };
        return random;
    });

angular
    .module('app')
    .controller('homeCtrl', ['$scope','Calculator', function ($scope,Calculator) {

        $scope.random = Calculator.number();

    }]);

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.23/angular.min.js"></script>

<div ng-app="app">
<div ng-controller="homeCtrl">{{random}}</div>
</div>

sdgluck · Accepted Answer · 2015-10-04 10:36:46Z

0

This should work:

angular
    .module('app', [])
    .factory('Calculator', function () {
        return function () {
            return Math.random();
        }
    });`

edited Oct 4, 2015 at 10:36

sdgluck

27.8k12 gold badges82 silver badges96 bronze badges

answered Oct 4, 2015 at 8:00

Tomer Keisar

614 bronze badges

Collectives™ on Stack Overflow

getting service instance in controller

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related