While loop running even after condition is False

Question

I want the user to input either 1, 2 or 3. But when I test it and enter 1,2 or 3 it still runs even though the condition is False. I keep changing the condition from and's and or's but I can't seem to solve it. Any help would be greatly appreciated.

def get_input():
    user_input = input("Enter a number 1,2 or 3:  ")

    while  (user_input != 1) and (user_input != 2) and (user_input != 3) :
        print('Invaild input!')
        user_input = input("Enter a number 1,2 or 3 : ")

Your assumption is wrong. The program is running as it has been told to do. Thus the expression is not false. — user2864740
– user2864740, Commented Oct 4, 2015 at 1:59
Thanks Jonathan, but how to deal with the user entering a string or a number that isnt 1 2 or 3 — user1995933
– user1995933, Commented Oct 4, 2015 at 2:02
You need to either test against strings or convert the input to an int. — lvc
– lvc, Commented Oct 4, 2015 at 2:04
There is probably a dupe of this somewhere, but that proposed dupe definitely isnt it. — lvc
– lvc, Commented Oct 4, 2015 at 2:05

ergonaut · Accepted Answer · 2015-10-04 02:02:23Z

1

You are reading strings, you should either convert it, or use strings. So the condition should be

(user_input != "1") and (user_input != "2") and (user_input != "3")

answered Oct 4, 2015 at 2:02

ergonaut

7,0671 gold badge21 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dwjohnston · Accepted Answer · 2015-10-04 02:02:44Z

1

Because the value returned from input() is a string (enclosed by quote marks), not an integer.

ie.

"1" is not the same thing as 1

To fix it change this line.

while  (user_input != "1") and (user_input != "2") and (user_input != "3") :

answered Oct 4, 2015 at 2:02

dwjohnston

12.5k39 gold badges119 silver badges220 bronze badges

Comments

Om Nigam · Accepted Answer · 2021-07-28 09:28:31Z

0

You can try to change the input data type to integer from string or rather use "2" instead of 2 in your code

For Using It Without Changing The Data Type:

def get_input():
user_input = input("Enter a number 1,2 or 3:  ")

while  (user_input != "1") and (user_input != "2") and (user_input != "3") :
    print('Invaild input!')
    user_input = input("Enter a number 1,2 or 3 : ")

For changing data type to int:

def get_input():
user_input = int(input("Enter a number 1,2 or 3:  "))

while  (user_input != 1) and (user_input != 2) and (user_input != 3) :
    print('Invaild input!')
    user_input = int(input("Enter a number 1,2 or 3 : "))

answered Jul 28, 2021 at 9:28

Om Nigam

1504 silver badges13 bronze badges

Collectives™ on Stack Overflow

While loop running even after condition is False

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related