Find max value in for loop range - Python

Question

I've been working on a small program that takes the input of two numbers and gives the greatest common divisor. I have managed to get the program to at least print out all common divisors until the greatest number is reached, but all I need to print is the max value. Unfortunately, I can't get seem to get this to work. I've tried passing i though max() but was received an error that ''int' objects are not iterable''. Thus I am wondering if anyone could help me find a solution that will allow me to print only the max value as opposed to all values without having to employ much more complex coding methods. Here is the code

def great_divisor():
m = int(raw_input("Choose a number"))
n = int(raw_input("Choose another number"))
#lowest number assigned to d
if m > n:
    d = n
else:
    d = m

for i in range(1, d + 1):

    if (n%i == 0 and m%i == 0):
        print(max(i))
return

d = min(m,n) should replace your if...else, for one thing. — Kyle Pittman
– Kyle Pittman, Commented Oct 8, 2015 at 18:17
Why not just use gcd from the fractions module? Related post. gcd is in the math module if you are using 3.3 — SirParselot
– SirParselot, Commented Oct 8, 2015 at 18:20
the point of the exercise isn't calculating gcd, but rather working with for loops. I would have if the point was to calculate that efficiently — prance
– prance, Commented Oct 8, 2015 at 18:23

Paul Boddington · Accepted Answer · 2015-10-08 18:28:50Z

1

The easiest way is to use range(d, 0, -1) and just return the first divisor you find. No need to use max.

edited Oct 8, 2015 at 18:28

answered Oct 8, 2015 at 18:23

Paul Boddington

37.8k10 gold badges69 silver badges120 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

prance Over a year ago

thanks that managed to reverse the numbers, now just to figure out how to get it to only return one divisor

Paul Boddington Over a year ago

Just do if (n%i == 0 and m%i == 0): return i

jcfollower · Accepted Answer · 2015-10-08 18:22:16Z

0

How about this?

maxn = 0
for i in range(1, d + 1):

    if (n%i == 0 and m%i == 0):
        maxn = i

return maxn

answered Oct 8, 2015 at 18:22

jcfollower

3,15822 silver badges26 bronze badges

1 Comment

prance Over a year ago

hmm, not working. Now the program just returns none as opposed to a number

mat__ · Accepted Answer · 2015-10-08 19:19:39Z

0

Max can only be applied to an iterable, a list for example.

You can add all the common divisor in a list and get the max.

for i in range(1, d + 1):
    if (n%i == 0 and m%i == 0):
        divisors.append(i)
print(max(divisors))

edited Oct 8, 2015 at 19:19

answered Oct 8, 2015 at 18:21

mat__

33 bronze badges

3 Comments

mat__ Over a year ago

Alternatively, you can declare a max_divisor variable and chek if i is greater than max_divisor.

prance Over a year ago

did you mean .add or .append? I had to use append to get the same effect. I'm running 2.7 though...

mat__ Over a year ago

Yes sorry, it is .append()

Collectives™ on Stack Overflow

Find max value in for loop range - Python

3 Answers 3

2 Comments

1 Comment

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related