Index was outside the bounds of the array in - C#

Question

I have a .txt file that is setup like this:

1 Username Email MD5Password PlainPassword

Now I want to put this .txt into SQL, so I have this code:

string[] SQL = line.Split(' ');

dynamic ID = SQL[0];
dynamic Username = SQL[1];
dynamic Email = SQL[2];
dynamic Password = SQL[3];
dynamic PlainPassword = SQL[4];

string lines = "INSERT INTO `dbsearch`(`username`, `password`, `email`, `extra`) VALUES ('" + Username + "', '" + Password + "', '" + Email + "', '" + PlainPassword + "')";

But some lines in my .txt file doesnt have a password or plainpassword, so I get this error:

Exception thrown: 'System.IndexOutOfRangeException' in Search SQL Creator.exe

Additional information: Index was outside the bounds of the array.

How can I fix this?

What don't you understand about the error message? You're accessing an index which is outside the bounds of your array. Are you sure you have 5 elements? — Yuval Itzchakov
– Yuval Itzchakov, Commented Oct 11, 2015 at 12:02
You can run the debugger and add a breakpoint at the first line. Please show the content of "SQL" at the execution. — Kevin Robatel
– Kevin Robatel, Commented Oct 11, 2015 at 12:02
Like I said, most of the times I have 5 elements, but sometimes there is not. So how can I just make it empty if there is not a element? — wtm
– wtm, Commented Oct 11, 2015 at 12:03
just check the size of SQL, and if it contains 5 values do as now, and if only 3 set default values for P and PP. — hoijui
– hoijui, Commented Oct 11, 2015 at 12:08
Why are you using dynamic when the values are clearly string? — Enigmativity
– Enigmativity, Commented Oct 11, 2015 at 13:47

Yuval Itzchakov · Accepted Answer · 2015-10-11 12:12:55Z

4

If you're not sure whether you have the last element, you can check before accessing it inside the array:

string[] sql = line.Split(' ');

dynamic id = sql[0];
dynamic username = sql[1];
dynamic email = sql[2];
dynamic password = sql.Length >= 4 ? sql[3] : null;
dynamic plainPassword = sql.Length == 5 ? sql[4] : null;

edited Oct 11, 2015 at 12:12

answered Oct 11, 2015 at 12:07

Yuval Itzchakov

150k32 gold badges276 silver badges333 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Enigmativity · Accepted Answer · 2015-10-11 13:50:55Z

0

You could also use LINQ:

string[] sql = line.Split(' ');

string id = sql[0];
string username = sql[1];
string email = sql[2];
string password = sql.Skip(3).FirstOrDefault();
string plainPassword = sql.Skip(4).FirstOrDefault();

answered Oct 11, 2015 at 13:50

Enigmativity

117k12 gold badges101 silver badges184 bronze badges

2 Comments

Yuval Itzchakov Over a year ago

This would redundantly enumerate the collection twice.

Enigmativity Over a year ago

@YuvalItzchakov - Possibly. At worst though this is only for 7 + 2 elements. Accessing 9 elements to get 2 from an array is hardly a performance issue. Besides, many of the LINQ operators recognize that they are iterating over arrays and do direct access.

Collectives™ on Stack Overflow

Index was outside the bounds of the array in - C#

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related