For loop not using argument from JavaScript function

Question

I'm trying to run this function in my server.js file:

function formatArr (targetArr, characteristic, formattedArr) {
    console.log(characteristic);
    for (var i = 0; i < targetArr.length; i++) {
        formattedArr.push({characteristic:targetArr[i]})
    };
    return formattedArr;
};

If I call it like so:

var targetSize = Object.keys(JSON.parse(req.query.size)); //[s,m,l]
var sizeKey = "size";
// format size array for mongodb query 
var formattedSize = [];
var formattedSize = formatArr(targetSize, sizeKey, formattedSize);
console.log(formattedSize);

it DOES console log "size", but it does NOT replace the word characteristic with the word size in the formattedSize array. Here's what I get in my server console:

size
[ { characteristic: 's' },{ characteristic: 'm' },{ characteristic: 'l' } ]

How do I make it replace characteristic with size within the array? This is my desired output:

size
[ { size: 's' },{ size: 'm' },{ size: 'l' } ]

I want to be able to reuse the formatArr function with other characteristics.

dfsq · Accepted Answer · 2015-10-16 20:54:08Z

5

You should use bracket notation for variable property names:

function formatArr (targetArr, characteristic, formattedArr) {
    console.log(characteristic);
    for (var i = 0; i < targetArr.length; i++) {
        var obj = {};
        obj[characteristic] = targetArr[i];
        formattedArr.push(obj);
    };
    return formattedArr;
};

A little verbose but still. If you are in ES2015 friendly environment you can use shorter syntax:

for (var i = 0; i < targetArr.length; i++) {
    formattedArr.push({[characteristic]: targetArr[i]});
};

answered Oct 16, 2015 at 20:54

dfsq

193k26 gold badges244 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

AtheistP3ace Over a year ago

We posted almost same answer at same time I would +1 you for great minds thinking alike but I am fresh out of votes today! =]

AtheistP3ace · Accepted Answer · 2015-10-16 20:54:51Z

2

Try this:

function formatArr (targetArr, characteristic, formattedArr) {
    for (var i = 0; i < targetArr.length; i++) {
        var obj = {};
        obj[characteristic:targetArr] = targetArr[i]
        formattedArr.push(obj)
    };
    return formattedArr;
};

answered Oct 16, 2015 at 20:54

AtheistP3ace

9,74112 gold badges45 silver badges43 bronze badges

Comments

Pointy · Accepted Answer · 2015-10-16 20:55:02Z

2

In very new JavaScript environments, you can write:

    formattedArr.push({ [characteristic]: targetArr[i] })

Otherwise, you'll have to build an object step-by-step as in @dfsq's answer.

answered Oct 16, 2015 at 20:55

Pointy

415k62 gold badges600 silver badges632 bronze badges

1 Comment

AtheistP3ace Over a year ago

Thats cool. I didn't know that! Thanks. Learn something new everyday.

Collectives™ on Stack Overflow

For loop not using argument from JavaScript function

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related