JSON: Uncaught TypeError: Cannot set property 'values' of undefined

Question

I am trying to pass the value of all the textareas on a page to a JSON table. For some reason I get a "cannot set value of undefined error", I dont understand since my Json is defined earlier.

Here is the code with the 2 functions.

function parseToJson() {
    var json = {};

    $("input.invoice_details").each(function () {
        json[this.id] = $(this).val();
    });

    $("select.invoice_details").each(function () {
        json[this.id] = $(this).val();
    });

    json.categories = {};

    $("textarea.invoice_categories").each(function () {
        if (this.value.trim() !== '') {
            json.categories[this.id].values = splitInput(this);
            json.categories[this.id].label = this.name;
        }
    });
    console.log(JSON.stringify(json));
    generatePreveiw(json);
}

function splitInput(textArea) {
    var input = textArea.value.trim();
    var lines = input.split("\n");
    var array = [];
    $.each(lines, function (indexLine, line) {
        var columns = line.split("\t");
        var obj = {};
        $.each(columns, function (indexColumn, column) {
            var columnName = columnsName.columnsName[indexColumn].name;
            obj[columnName] = column;
        });
        array.push(obj);
    });
    return array;
}

var json = {}; — That isn't JSON. That is a JavaScript object. JSON is an external data format that happens to be inspired by JavaScript literal syntax. — Quentin
– Quentin, Commented Oct 21, 2015 at 9:48

Barmar · Accepted Answer · 2015-10-21 09:52:11Z

4

        json.categories[this.id].values = splitInput(this);
        json.categories[this.id].label = this.name;

should be:

        json.categories[this.id] = {
            values: splitInput(this),
            label: this.name
        };

You can't set the properties of an object when you haven't created the object first. You can use this object literal syntax to create the object and its properties in one step.

answered Oct 21, 2015 at 9:52

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Quentin · Accepted Answer · 2015-10-21 09:47:14Z

0

json.categories = {};

You have an empty object

json.categories[this.id].values = splitInput(this);

Now you are trying to access a property called this.id from that object.

Since the object doesn't have any properties yet, that will always be undefined

You then try to assign undefined.value = splitInput(this), which throws an error.

You need to make sure json.categories[this.id] has a value before you can set properties on it.

answered Oct 21, 2015 at 9:47

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Comments

Don · Accepted Answer · 2015-10-21 09:49:11Z

0

The problem is that you are trying to access a property of the object stored in json.categories[this.id]. Unfortunately it is undefined. Try the following:

function() {
        if (this.value.trim() !== '')
        { 
            //Initialize to an empty object if necessary
            json.categories[this.id] = json.categories[this.id] || {};
            json.categories[this.id].values = splitInput(this);
            json.categories[this.id].label = this.name;
        }
    });

answered Oct 21, 2015 at 9:49

Don

6,9204 gold badges29 silver badges35 bronze badges

Collectives™ on Stack Overflow

JSON: Uncaught TypeError: Cannot set property 'values' of undefined

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related