Java replaceAll with regex only replacing first instance

Question

I am trying to update all url's in a CSS string and my regex only seems to get the first one. I want to get anything like:

url("file")
url('file');
url(file);

I also want to exclude things where the url is data:

url("data: ...");
url('data: ...');
url(data: ...);

I wrote some code to do this, but it only replaces the first one:

String str = ".ff0{font-family:sans-serif;visibility:hidden;}@font-face{font-family:ff1;src:url(f1.woff)format(\"woff\");}.ff1{font-family:ff1;line-height:1.330566;font-style:normal;font-weight:normal;visibility:visible;}@font-face{font-family:ff2;src:url(f2.woff)format(\"woff\");}.ff2{font-family:ff2;line-height:1.313477;font-style:normal;font-weight:normal;visibility:visible;}@font-face{font-family:ff3;src:url(f3.woff)format(\"woff\");}.ff3{font-family:ff3;line-height:1.386719;font-style:normal;font-weight:normal;visibility:visible;}@font-face{font-family:ff4;src:url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI1IiBoZWlnaHQ9IjUiPgo8cmVjdCB3aWR0aD0iNSIgaGVpZ2h0PSI1IiBmaWxsPSIjOWU5ZTllIj48L3JlY3Q+CjxwYXRoIGQ9Ik0wIDVMNSAwWk02IDRMNCA2Wk0tMSAxTDEgLTFaIiBzdHJva2U9IiM4ODgiIHN0cm9rZS13aWR0aD0iMSI+PC9wYXRoPgo8L3N2Zz4=)format(\"woff\");";
str = str.replaceAll("url\\((['\"]?)(?!data)(.*)\\1\\)","url(someURL/$2)");
out.println(str);

Any ideas on how to fix? I imagine it has something to do with the regex.

str = str.replaceAll(/url$(['\"]?)(?!data)(.*)\\1$/g,"url(someURL/$2)"); You need to set the global identifier... the /g — An0nC0d3r
– An0nC0d3r, Commented Oct 21, 2015 at 18:56
Aren't you thinking of javascript? When I do this in java, I get a load of errors. — fanfavorite
– fanfavorite, Commented Oct 21, 2015 at 19:00
Try with reluctant quantifier. So instead of (.*) use (.*?) — Pshemo
– Pshemo, Commented Oct 21, 2015 at 19:02
str = str.replaceAll("url\$(['\"]?)(?!data)(.*?)\\1\$", "url($1someURL/$2$1)"); — anubhava
– anubhava, Commented Oct 21, 2015 at 19:03

Alexey Subach · Accepted Answer · 2015-10-21 19:41:25Z

3

You probably want to use non-greedy quantifier (*? instead of *).

To exclude the data entries properly, also use possessive quantifier for capturing the qoutes: ?+ instead of ?.

So your regex should look as follows: url$(['"]?+)(?!data)(.*?)\1$ Note that you should probably escape some characters with extra slash as you did in your example.

edited Oct 21, 2015 at 19:41

answered Oct 21, 2015 at 19:01

Alexey Subach

12.4k7 gold badges40 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

fanfavorite Over a year ago

That works thanks. Just one issue that I need to solve is that when data is surrounded by single or double quotes, it passes the regex. How would I fix that?

Alexey Subach Over a year ago

For that you would want to use possessive quantifier for matching these quotes: ?+ instead of ?: url$(['"]?+)(?!data)(.*?)\1$

Crunch · Accepted Answer · 2015-10-21 19:07:13Z

2

Your .* is greedy. It's capturing to the end of the string. Use .*?, instead, which will force the engine to capture as few characters as possible.

str = str.replaceAll("url\\((['\"]?)(?!data)(.*?)\\1\\)","url(someURL/$2)");

answered Oct 21, 2015 at 19:07

Crunch

5103 silver badges10 bronze badges

4 Comments

fanfavorite Over a year ago

Thanks. Any idea how to fix the issue where it would apply when data is surrounded by single or double quotes?

Crunch Over a year ago

I'm not clear what exact issue you're trying to address. The regex above already captures a url that is within single or double quotes into the second capture group. Are you trying to retain quotes after the string replacement?

fanfavorite Over a year ago

If you look above at the data urls I posted to exclude, this regex only excludes ones without single and double quotes. I want to make sure that it excludes all data urls.

Crunch Over a year ago

Sorry. I missed that you wanted to exclude data above. Got it.

frosty · Accepted Answer · 2015-10-21 20:14:46Z

0

Something like this should work:

~\((?!.*data).+\)~

answered Oct 21, 2015 at 20:14

frosty

2,67910 gold badges42 silver badges86 bronze badges

Collectives™ on Stack Overflow

Java replaceAll with regex only replacing first instance

3 Answers 3

2 Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related