Java comma "," in forEach [duplicate]

Question

I have got a little problem with printing out comma in my java project. In forEach section the program is always printing out "," > even after the last word... see output

.listener("lookAround", (Game g, String action, AbstractGameObject object, Object retVal) -> {
    System.out.print("You see: \n\t");

    if (g.getItemsInRoom((Room) object).isEmpty() && g.getDoorsInRoom((Room) object).isEmpty())
       System.out.print("nothing");

    g.getItemsInRoom((Room) object)
                     .stream()
                     .forEach(item -> System.out.print(item.getName() + ", "));

    g.getDoorsInRoom((Room) object)
                     .stream()
                     .forEach(door -> System.out.print(door.getName() + ", "));
    System.out.println("\n");
})

The output:

You see:    
Black Wooden door, Brown Wooden door,

I would like output:

You see:    
Black Wooden door, Brown Wooden door

Is there a easy way to solve this problem ? Thank you for a help :)

Wormbo · Accepted Answer · 2015-10-24 14:06:40Z

3

I don't think you should be printing inside that forEach lambda. Actually I'm not even sure you should be using the stream API there.

Think about using String.join() or the StringJoiner class instead.

answered Oct 24, 2015 at 14:06

Wormbo

5,0102 gold badges23 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Holger · Accepted Answer · 2015-10-24 14:37:33Z

1

Using a StringJoiner directly, rather than via the Stream API, let’s you handle the empty case without additional code:

StringJoiner j=new StringJoiner(", ").setEmptyValue("nothing");
g.getItemsInRoom((Room)object).forEach(o -> j.add(o.getName()));
g.getDoorsInRoom((Room)object).forEach(o -> j.add(o.getName()));
System.out.println("You see: \n\t"+j);

answered Oct 24, 2015 at 14:37

Holger

301k43 gold badges481 silver badges827 bronze badges

1 Comment

Kolos Fuchs Over a year ago

Thank you very much, your solution helped a lot :)

Collectives™ on Stack Overflow

Java comma "," in forEach [duplicate]

2 Answers 2

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Linked

Related