Updating database with foreach is changing the array before updating

Question

I have an array with names, goal differences and so on for football teams that I want to put in a table, but during the foreach the last key in the array is changed somehow.

Last two keys before foreach

    [18] => Array
        (
            [team_code] => 4
            [team_name] => Newcastle
            [points] => 6
            [goals_for] => 12
            [goals_against] => 22
            [goal_difference] => -10
        )

    [19] => Array
        (
            [team_code] => 7
            [team_name] => Aston Villa
            [points] => 4
            [goals_for] => 9
            [goals_against] => 17
            [goal_difference] => -8
        )

)

After foreach

    [18] => Array
        (
            [team_code] => 4
            [team_name] => Newcastle
            [points] => 6
            [goals_for] => 12
            [goals_against] => 22
            [goal_difference] => -10
        )

    [19] => Array
        (
            [team_code] => 4
            [team_name] => Newcastle
            [points] => 6
            [goals_for] => 12
            [goals_against] => 22
            [goal_difference] => -10
        )

)

My foreach looks like this

  foreach ($teams as $team) {
    $team_code = $team['team_code'];
    $team_name = $team['team_name'];
    $points = $team['points'];
    $goals_for = $team['goals_for'];
    $goals_against = $team['goals_against'];
    $goal_difference = $team['goal_difference'];

    if ($update_query = $conn->query("UPDATE teams SET points = $points, goals_for = $goals_for, goals_against = $goals_against, goal_difference = $goal_difference WHERE team_code = $team_code")) {
      echo 'Updated '.$team_name.'<br>';
    } else {
      $update_query->error;
    }
  }

Why is the last key changed? It happens before the query is run, because the row doesn't get updated. All the others update as they should.

put some echo/print_r/var_dump and check your outputs and SQL statements... — Aaron Gong
– Aaron Gong, Commented Oct 28, 2015 at 13:41

Jeppe Willesen Smith · Accepted Answer · 2015-10-28 13:48:08Z

1

Thanks to VolkerK I managed to solve it.

I have another foreach with a reference to &$team before the foreach, and putting unset($team) between the two foreachs solved the problem.

answered Oct 28, 2015 at 13:48

Jeppe Willesen Smith

1151 gold badge1 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arron H · Accepted Answer · 2015-10-28 13:49:29Z

0

I don't think that there's anything wrong with your php script. I would take a look at how the array is build before it get to the foreach loop. How is the form for which you enter the data set up. If you are entering multiple teams at once, how are you differentiating the elements

answered Oct 28, 2015 at 13:49

Arron H

366 bronze badges

Collectives™ on Stack Overflow

Updating database with foreach is changing the array before updating

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related