David Turnbull Adding a score field to an add player form not sorting properly

Question

if anyone completed or is following David Turnbull's 'Creating your first Meteor app' this is a question from that.

On page 102 it says to "Add a “Score” field to the “Add Player” form, allowing users to define a score for a player when they’re being submitted to the list."

I figured out how to do it, using this in my leaderboard.js file:

Template.addPlayerForm.events({
  'submit form': function (event) {
    event.preventDefault();
    var playerNameVar = event.target.playerName.value;
    var playerScoreVar = event.target.playerScore.value;
    PlayersList.insert({
      name: playerNameVar,
      score: playerScoreVar
    });
    var playerNameVar = event.target.playerName.value = "";
    var playerScoreVar = event.target.playerScore.value = "";
  }
});

And in my leaderboard.html file:

<template name="addPlayerForm">
  <form>
    <input type="text" name="playerName">
    <input type="number" name="playerScore">
    <input type="submit" value="Add Player">
   </form>
</template>

When a new player is created, the player is put at the top of the list regardless of their score. Which is sorted using this:

Template.leaderboard.helpers({
  'player': function(){
      return PlayersList.find({}, {sort: {score: -1, name: 1} });
      // -1 sorts descending, while 1 will sort ascending
  },
  ...
});

My guess is maybe I am not defining the score properly. Any help would be great!

MasterAM · Accepted Answer · 2015-10-29 22:25:42Z

1

The value of an input, even one with type="number", is still a string.

Therefore, if inserted as a string, it appears to have the highest value.

You should parse an int out of it and validate it:

var playerScoreVar = parseInt(event.target.playerScore.value, 10);
// validation logic may go here or be placed in a method.
...

answered Oct 29, 2015 at 22:25

MasterAM

16.5k6 gold badges47 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bart Dangus Over a year ago

Awesome. Thank you, I also found a couple other ways to do it: right here

Collectives™ on Stack Overflow

David Turnbull Adding a score field to an add player form not sorting properly

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related