What's wrong with this javascript function?

Question

I am using the following javascript regex email validate function but it doen't seem to work why....

function IsValidEmail(email) {
    var filter = /^([\w-\.]+)@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|[0-9]{1,3})(\]?)$/;
    return filter.test(email);
}

function forgetpassword() {
    if (document.getElementById("ctl00_TxtEmailId").value == "") {
        return false;// this condition gets exected so no prob with my txtboxID
    }
    if (document.getElementById("ctl00_TxtEmailId").value != "") {
        return IsValidEmail(document.getElementById("ctl00_TxtEmailId").value);
    }
    return true;
}

My failed inputs were test,test@test and also [email protected]

Guys my textbox is within a facebox modal popup.... when i tried alert(document.getElementById("ctl00_TxtEmailId").value with some text jsadf the alert displayed with nothing... Why?

What do you mean by "doesn't work"? False positive or false negative? — kennytm
– kennytm, Commented Jul 27, 2010 at 10:52
If your house has a hole in the roof, do you call the maintenance guy and say "my house doesn't work"? How about being a bit more specific about how it fails to work exactly. — Matti Virkkunen
– Matti Virkkunen, Commented Jul 27, 2010 at 10:54

Janus Tøndering · Accepted Answer · 2010-07-27 11:10:18Z

1

I would change the regexp to something like

/^[a-zA-Z0-9._-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,4}$/

and I would rewrite forgetpassword to

function forgetpassword() {
    return IsValidEmail(document.getElementById("ctl00_TxtEmailId").value);
}

Edit: Complete function

function IsValidEmail(email) {
    var filter = /^[a-zA-Z0-9._-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,4}$/
    return filter.test(email);
}

IsValidEmail('[email protected]') -> true in Chrome / IE8

edited Jul 27, 2010 at 11:10

answered Jul 27, 2010 at 10:59

Janus Tøndering

9246 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Janus Tøndering Over a year ago

Have you checked the value of document.getElementById("ctl00_TxtEmailId").value? I don't have problems with this snippet.

Josh · Accepted Answer · 2010-07-27 11:10:10Z

0

Want to try this?

/^[a-zA-Z][\w.-][a-zA-Z0-9]@[a-zA-Z0-9][\w.-][a-zA-Z0-9].[a-zA-Z][a-zA-Z.]*[a-zA-Z]$/

answered Jul 27, 2010 at 11:10

Josh

1

Collectives™ on Stack Overflow

What's wrong with this javascript function?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related