Error when running linq query

Question

I'm receiving this error

"{"There is already an open DataReader associated with this Command which must be closed first."}"

Here is the code that it errors on.

var summaryViewModel = new YogaSpaceSummaryViewModel
            {
                SpaceImage = (from u in space.Images orderby u.Ordering ascending select u.ImageThumbnail).First(),
                Title = space.Overview.Title,
                SpaceId = space.YogaSpaceId,
                DateCreated = space.DateCreated.ToShortDateString(),
                StepsToList = space.StepsToList,
                Status = space.Status
            };

which part of this code here

YogaSpaceOverviewViewModel overviewViewModel = new YogaSpaceOverviewViewModel();

        foreach (YogaSpace space in yogaSpaces)
        {
            var summaryViewModel = new YogaSpaceSummaryViewModel
            {
                SpaceImage = (from u in space.Images orderby u.Ordering ascending select u.ImageThumbnail).First(),
                Title = space.Overview.Title,
                SpaceId = space.YogaSpaceId,
                DateCreated = space.DateCreated.ToShortDateString(),
                StepsToList = space.StepsToList,
                Status = space.Status
            };

            overviewViewModel.YogaSpaceSummarys.Add(summaryViewModel);
        }

As the message suggests, check if any of your previously opened/used DataReaders is properly closed. — MusicLovingIndianGirl
– MusicLovingIndianGirl, Commented Nov 4, 2015 at 4:46
If the datareader is null. Make sure when the reader is closed you set it to null. It is automatically null initially. — jdweng
– jdweng, Commented Nov 4, 2015 at 4:47
I placed a .ToList() after yogaSpaces in the foreach loop and that seemed to fix it. — chuckd
– chuckd, Commented Nov 4, 2015 at 4:51

Ross Bush · Accepted Answer · 2015-11-04 04:53:31Z

1

You might want to wrap downward using a using so the scope will cause all objects to bedisposed. Also, to circumvent a lzy loading issue with disposed datacontext's you will probally be better served to ToList() ot FirstOrDefault() any result you are returning to ensure the collection has been enumerated and if the context is disposed then everything is dandy.

answered Nov 4, 2015 at 4:53

Ross Bush

15.2k2 gold badges39 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rakin · Accepted Answer · 2015-11-04 04:51:14Z

0

 <connectionStrings>
 <add name="DatabaseEntities" connectionString="metadata=res://*/Database.csdl|res://*/Database.ssdl|res://*/Database.msl;provider=System.Data.SqlClient;provider connection string=&quot;Data Source=Server;Initial Catalog=Database;Persist Security Info=True;User ID=sa;Password=passowrd;MultipleActiveResultSets=True;Application Name=EntityFramework&quot;" providerName="System.Data.EntityClient" />
 </connectionStrings>

Enable MultipleActiveResultSets in Webconfig

answered Nov 4, 2015 at 4:51

Rakin

1,28914 silver badges31 bronze badges

Comments

amit dayama · Accepted Answer · 2015-11-04 04:55:03Z

0

Add MultipleActiveResultSets=true to the provider part of your connection string (where Data Source, Initial Catalog, etc. are specified).

answered Nov 4, 2015 at 4:55

amit dayama

3,3462 gold badges19 silver badges28 bronze badges

Collectives™ on Stack Overflow

Error when running linq query

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related