multiple row saving to DB table

Question

I have to save more than one row of data into database table.

I wrote this code for that. But when i run this code, two rows will be saved into two rows of db table, but every other row is same as the last row data.

i.e. that is the last row data is overwriting every other row data.

$values = array();

if (isset($_POST['sub_save'])) {
    $row_count = $_POST['rowcount'];

    while ($row_count > 0) {
        for ($r = 1; $r <= 2; $r++) {
            $val = $_POST['txt'.$row_count.$r];
            $values[] = $val;
        }

        $row_count = $row_count - 1;
        $sql = "insert into timesheet_entry (name, address) values ('$values[0]', '$values[1]')";

        if (mysql_query($sql)) {
            echo "inserted";
        } else {
            echo "fail";
        }
    }
}

The way you are structuring the data in the posting HTML is horrible and likely the cause of the problem here. — symcbean
– symcbean, Commented Nov 6, 2015 at 12:45
From the beginning - but I suspect that's not the answer you're looking for. Don't try to amalgamate pre-generated, surrogate keys into a composite key (or if you must, at least delimit the components). — symcbean
– symcbean, Commented Nov 6, 2015 at 13:11
omg im a begginer can you tell me in a simpler way!!!!!!!!!!!!!!!!! — Dew Drop
– Dew Drop, Commented Nov 6, 2015 at 13:28
I can't tell you how you you should structure unless I know a lot more about it. — symcbean
– symcbean, Commented Nov 6, 2015 at 13:30

Danny · Accepted Answer · 2015-11-06 15:37:11Z

1

You aren't resetting your values array inside the loop so values[0] and values[1] will always have the first to values.

if (isset($_POST['sub_save'])) {
    $row_count = $_POST['rowcount'];

    while ($row_count > 0) {
        $values = array();
        for ($r = 1; $r <= 2; $r++) {
            $val = $_POST['txt'.$row_count.$r];
            $values[] = $val;
        }

        $row_count = $row_count - 1;
        $sql = "insert into timesheet_entry (name, address) values ('$values[0]', '$values[1]')";

        if (mysql_query($sql)) {
            echo "inserted";
        } else {
            echo "fail";
        }
    }
}

On a sidenote I would recommend looking into the PDO extension and parameterised queries as mysql_ is deprecated and the above code is vulnerable to SQL injection

answered Nov 6, 2015 at 15:37

Danny

7298 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

zwergmaster · Accepted Answer · 2015-11-06 12:30:08Z

0

You are mixing mysql and mysqli:

$conn = mysqli_connect("localhost", "root", ""); 
$db = mysqli_select_db("dbname");

if (mysqli_query($sql)) {
   echo "inserted";
} else {
   echo "fail";
}

edited Nov 6, 2015 at 12:30

zwergmaster

2632 silver badges12 bronze badges

answered Nov 6, 2015 at 12:25

Niranjan N Raju

12k4 gold badges24 silver badges41 bronze badges

1 Comment

Dew Drop Over a year ago

ok i will correct it but the problem is rows are saving but the last row data overwriting the above rows..can you help me with that?

Collectives™ on Stack Overflow

multiple row saving to DB table

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related