PHP json encode foreach only loops through the first item

Question

So I'm busy at creating a system. That system generates a bit of JSON

For example:

{
    "Builds": [
        {
            "title": "test",
            "item1": "3",
            "item2": "3",
            "item3": "0",
            "item4": "0",
            "item5": "0",
            "item6": "0"
        },
        {
            "title": "test2",
            "item1": "3",
            "item2": "3",
            "item3": "2",
            "item4": "0",
            "item5": "0",
            "item6": "0"
        }
    ]
}

Now im trying to get every "build" with a foreach in PHP this only loops the first time and then does nothing.

$i = 0;

foreach($builds as $build){
    //echo $i;
    echo $build[$i]['title'];
    echo '<img src="' . $build[$i]['item1'] . '" alt=""></img>';
    $i++;
}

Why are you using a counter? Get rid of it. echo $build['title']; etc — John Conde
– John Conde, Commented Nov 12, 2015 at 19:14
@JohnConde The json file makes me using the counter. Unless im going with another JSON structure. But thats still not an answer to my question, about how to solve it. Cuase i think it is strange it only loops one time.. — Roy Stijsiger
– Roy Stijsiger, Commented Nov 12, 2015 at 19:18

Philipp · Accepted Answer · 2015-11-12 19:16:48Z

1

Because of the for loop, you don't need a counter.

$json = '{"Builds":[{"title":"test","item1": "3","item2": "3","item3": "0","item4": "0","item5": "0","item6": "0"},{"title":"test2","item1": "3","item2": "3","item3": "2","item4": "0","item5": "0","item6": "0"}]}';
$data = json_decode($json, true);
$builds = $data['Builds'];
foreach($builds as $build){
    echo $build['title'];
    echo '<img src="' . $build['item1'] . '" alt=""></img>';
}

The only reason for a counter would be, if you want to iterate over the item elements in your builds.

for ($i = 1; isset($build['item' . $i]); $i++) {
    echo '<img src="' . $build['item' . $i] . '" alt=""></img>';
}

answered Nov 12, 2015 at 19:16

Philipp

15.7k4 gold badges38 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Roy Stijsiger Over a year ago

If i do it without the coutner it still doesnt work. I am getting an undefinded index error.

AbraCadaver Over a year ago

Probably want foreach($builds['Builds']

Philipp Over a year ago

If you get an undefined index error, your $build var doesn't contain the content of the json you posted - if you tried my code, you would see, that it actually worked

Hasse Björk Over a year ago

Does it? $build['item1'] is an object: $build->item1, $build->title and $data->Builds

Philipp Over a year ago

@HasseBjörk json_decode as second param, which indicates that the return value is an assoc array

|

CodeGodie · Accepted Answer · 2015-11-12 19:25:27Z

1

You're working with an array of objects. This is how you should be doing it:

<?php

$json = ""; //your JSON string
$obj = json_decode($json);
foreach ($obj->Builds as $build) {
    echo $build->title;
    echo "<img src='$build->item1' alt=''>";
}

?>

answered Nov 12, 2015 at 19:25

CodeGodie

12.2k6 gold badges40 silver badges66 bronze badges

1 Comment

Roy Stijsiger Over a year ago

Im using json_decode($build,true) which only returns arrays:)

Hasse Björk · Accepted Answer · 2015-11-12 19:22:46Z

0

This is a working version

$builds = '{"Builds":[{"title":"test","item1": "3","item2": "3","item3": "0","item4": "0","item5": "0","item6": "0"},{"title":"test2","item1": "3","item2": "3","item3": "2","item4": "0","item5": "0","item6": "0"}]}';

foreach(json_decode( $builds )->Builds as $build ){
    echo $build->title;
    echo '<img src="' . $build->item1 . '" alt=""></img>';
}

First you need to use the json decoded object Builds to iterate through. This will give you objects to display, like $build->title

answered Nov 12, 2015 at 19:22

Hasse Björk

1,61114 silver badges19 bronze badges

2 Comments

Roy Stijsiger Over a year ago

They arent objects though cause i use json_decode($builds,true) only arrays are given back as return value

Hasse Björk Over a year ago

I did not see that in your example... Well, this does work!

Collectives™ on Stack Overflow

PHP json encode foreach only loops through the first item

3 Answers 3

7 Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

7 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related