PHP OOP Config Class

Question

I have a little problem. I have make a config class which automaticlly return the value that i want.

usage example:

echo Config::get('database.host');

This returns localhost.

But if i have multiple vars then it returns the first i selected.

example:

echo Config::get('database.host');
echo Config::get('database.username');
echo Config::get('database.password');
echo Config::get('database.name');

all returns localhost.

here is my config class:

<?php

namespace App\Libraries;

class Config
{
  private static $_config;

  public static function set($config)
  {
    self::$_config = $config;
  }

  public static function get($var = null)
  {
    $var = explode('.', $var);

    foreach ($var as $key) {
      if (isset(self::$_config[$key])) {
        self::$_config = self::$_config[$key];
      }
    }

    return self::$_config;
  }

  public function __destruct()
  {
    self::$_config = null;
  }
}

?>

i initialisate it like this:

Config::set($config);

the $config variable contains my entire config file:

 <?php

 $config = [
    'database' => [
    'host'     => 'localhost',
    'name'     => 'dev',
    'charset'  => 'utf8',
    'username' => 'root',
    'password' => '1234'
  ]
];

?>

Hope you can help me guys :) (Sorry for bad english)

Marc B · Accepted Answer · 2015-11-16 19:14:41Z

1

Well, yeah. The first time you call get(), you destroy all the other config options:

Config::set($config); // sets your nested array
Config::get('foo.bar');
     self::$_config = self::$_config['foo'];
           ^^^^^^^^--overwrite this
                            ^^^^^^^^^^^^---with the foo sub value
     self::$_config = self::$_config['bar'];
           ^^^^^^^^--overwrite the previous foo value
                              ^^^^^^^---with bar's

Then the next time you call get(), you're not accessing your original $_config array. you're accessing whatever value was retrieved with the LAST get() call.

You need to use a temp variable, e.g.

Config::get('foo.bar')

   explode ...
   $temp = self::$_config;
   foreach(... as $key) {
      $temp = $temp[$key];
   }
   return $temp;

answered Nov 16, 2015 at 19:14

Marc B

362k44 gold badges433 silver badges508 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP OOP Config Class

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related