Why doesn't script recognise empty src?

Question

I have this code that checks if an img src is empty:

 if (document.getElementById('featuredIconImage348790').src == "") {
 document.getElementById('featuredIconImage348790').style.display = 'none';
  }

The src is empty but the code does not hide the image? Is there a problem that I missed?

Remove the == "" part and see what happens. Is 'featuredIconImage348790' really the HTML id attribute for that image? Is that even an image? HTML please. — StackSlave
– StackSlave, Commented Nov 25, 2015 at 0:01
console.log(document.getElementById('featuredIconImage348790').src)? — EvilZebra
– EvilZebra, Commented Nov 25, 2015 at 0:03
Ah, does that image element exist at the time you run the script? If not, you probably have an error in your console waiting to be read — Phil
– Phil, Commented Nov 25, 2015 at 0:03
@ERN check the answers bellow, if the answer help vote it up, if the answer is really what you loking for mark it as accepted answer. — Zakaria Acharki
– Zakaria Acharki, Commented Nov 25, 2015 at 9:08

Zakaria Acharki · Accepted Answer · 2015-11-25 00:16:42Z

2

Try to use getAttribute() instead :

if (document.getElementById('featuredIconImage348790').getAttribute('src') == "" ){
     document.getElementById('featuredIconImage348790').style.display = 'none';
}

When you have no src attribute like :

<img id="featuredIconImage348790" />

You have to make condition like == null because getAttribute() method will return null.

And if you have empty src attribute like :

<img id="featuredIconImage348790" src=""/>

You can make condition that check if empty == "".

Hope this helps.

edited Nov 25, 2015 at 0:16

answered Nov 25, 2015 at 0:07

Zakaria Acharki

67.5k15 gold badges79 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Phil Over a year ago

Wasn't sure why this made a difference until I saw the other answer. +1

Merott · Accepted Answer · 2015-11-25 00:07:24Z

1

The src of the img is considered to be relative - in this case a relative empty string, so it becomes prefixed with the hostname, as the snippet below demonstrates. Try getAttribute('src').

document.write('"' + document.getElementById('featuredIconImage348790').src + '"');
document.write('<br>');
document.write('"' + document.getElementById('featuredIconImage348790').getAttribute('src') + '"');

<img id="featuredIconImage348790" src="" />

answered Nov 25, 2015 at 0:07

Merott

7,4096 gold badges42 silver badges53 bronze badges

Collectives™ on Stack Overflow

Why doesn't script recognise empty src?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related