jquery parsing Json into var with .each

Question

Need help understanding how to get this to work.

Given:

var data = {"time":"20151206212722","Irms":"2940"}

and:

<script type="text/javascript">
    $.ajaxSetup({
      cache: false
    });
    setInterval(function() {
      $(function() {
        $.get("data-upload_emon.txt", function(data, textStatus) {
          console.log(data);
          $.each(data, function(key, value) {
            console.log(key);
            console.log(value);
            Irms = value.Irms
            console.log(Irms);

            $("#ajax1").fadeOut(200, function() {
              $("#ajax1").html(
                time
              ).fadeIn(2);
            }),
              $("#ajax2").fadeOut(200, function() {
              $("#ajax2").html(
                Irms
              ).fadeIn(2);
            })
          });
        },
              "json"
             );
      })
    }, 10000);
</script>

Why is var Irms undefined? First three console logs return what is expected. Console.log(Irms) returns as "undefined"

Thank you!! This is driving me crazy.

Try defining Irms before assigning anything to it, something like var Irms = value.Irms console.log(Irms); — Guruprasad J Rao
– Guruprasad J Rao, Commented Dec 7, 2015 at 6:50

Gavin Mogan · Accepted Answer · 2015-12-07 06:49:37Z

1

You have a lot of console.logs and didn't really state where the problem was occurring and a bunch of very minor syntax issues which could lead to weird behaviors.

According to your first example, data is just an object, not an array, so you shouldn't need to .each it. In addition, as the comment says, getJSON might produce a little readable code.

Also, unrelated, I'd use .text over .html so its properly escaped unless you are injecting html.

My untested suggestion is:

setInterval(function() {
  $.getJSON("data-upload_emon.txt", function(data) {
    console.log("data is", data);
    $("#ajax1").fadeOut(200, function() {
       $("#ajax1").html(data.time).fadeIn(2);
    });
    $("#ajax2").fadeOut(200, function() {
      $("#ajax2").html(data.Irms).fadeIn(2);
    })
  });
}, 10000);

Note the lack of the .each, removed the rogue comma between ajax1 and ajax2 and used data directly.

If you still want to use the Irms variable as you had it, I'd stick a var infront of it to make sure its defined in the proper scope.

answered Dec 7, 2015 at 6:49

Gavin Mogan

1,5471 gold badge14 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Baobab Over a year ago

Thank you! I had to add $.ajaxSetup({ cache: false }); back in. Now it works perfectly.

Gavin Mogan Over a year ago

Cool! Did what I say make sense to why it wasn't working? Also do you want to accept the answer?

vijayP · Accepted Answer · 2015-12-07 06:54:47Z

From your code $.each(data, function(key, value) { you are iterating over all the properties of the JSON object and hence Irms = value.Irms is not a valid statement.

If you have input data like this: var data = {"time":"20151206212722","Irms":"2940"}; then if you want to fetch the Irms then you really don't need $.each loop. You just need to parse the JSON object and simply need to fetch the required property as below:

var data = '{"time":"20151206212722","Irms":"2940"}'; //JSON in string format
var obj = JSON.parse(data); //parsing it to get actual JSON object
Irms = obj.Irms //fetching Irms property of the object
console.log(Irms);

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>

Collectives™ on Stack Overflow

jquery parsing Json into var with .each

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related