I picked up a project that another developer built. He has some of the JavaScript on the actual php page which is making debugging difficult.
<button type="submit" onclick="doFunction(event)">Done</button>
I have tried to move it to a javascript file:
$( document ).ready(function() {
function doFunction(e){}
});
and removing it from the PHP page but now it's not firing. Why is it not working now and how do I fix it?
You've defined function doFunction(e){} inside another function.
That locally scopes it. It is not a global. It is not accessible from onclick attributes (since they aren't defined inside the same function).
Don't use onclick attributes, they have many problems, bind your event handlers with JavaScript instead.
Since you are using jQuery:
$('button').on('click', doFunction);
You can use a more specific selector if you like.
That said, almost anything you want to do with a submit button is clicked is better done when a form is submitted.
$('form').on('submit', doFunction);
function doFunction(e) in the global scope and not inside the $( document ).ready function call. If you don't want to pollute the global scope, you can define an object in the global scope with doFunction as one of it's properties.
window['doFunction'] = function(e){} But this is bad practice
window.doFunction = function(e){ ... };
<script src="yourcode.js"></script>? the browser isn't going to magically realize that you moved the code elsewhere.eis undefined within your.ready(). I suggest you look at your js console for errors.<button type="submit" onclick="doFunction(event)">Done</button>or is that the previous solution that you've removed?