unexpected identifier error in javascript

Question

I am getting an unexpected identifier error for the following function.

function merge (one, two) {
    one.forEach(function(assign){

     //////////this next line is throwing the error////////////
        if (two.some(function(req) req.related == assign.rid)) {
            if (one.some(function(iter) iter.rid == req.rid)) {
                iter.quantity++;
            } else {
                one.push(req);
            }
        }
    });

    return one; 
}

The function is intended to operate on an array of objects.

I'm 2/3ds sure you have to use braces around the anonymous function body, and that that confuses the parser into trying to evaluate req: function(req) { req.related == assign.rid } — millimoose
– millimoose, Commented Dec 21, 2015 at 7:01
To make your questions easier to answer well, you should consider making a Minimal, Complete, Verifiable example — millimoose
– millimoose, Commented Dec 21, 2015 at 7:02
@millimoose You're right, I was afraid if I omitted any code it would remove necessary information. I'm new enough to javascript to make that mistake. — Suavocado
– Suavocado, Commented Dec 21, 2015 at 7:05
Well, I also had in mind adding some code where merge() is called with example inputs. It's not obvious what would be valid input here beyond "arrays." But generally, the process of removing code, while retesting to make sure the error still crops up will, in cases like these, usually lets you find the error on your own in the first place. Kind of like a doctor poking a patient all over to figure out where it hurts. — millimoose
– millimoose, Commented Dec 21, 2015 at 7:34

void · Accepted Answer · 2015-12-21 07:03:02Z

4

You have missed some { } around .some(function()...

function merge (one, two) {
    one.forEach(function(assign){

        if (two.some(function(req){ req.related == assign.rid})) {
                               // ^-- This one you missed
            if (one.some(function(iter){ iter.rid == req.rid})) {
                                    // ^-- This one you missed as well
                iter.quantity++;
            } else {
                one.push(req);
            }
        }
    });

    return one; 
}

answered Dec 21, 2015 at 7:03

void

36.8k10 gold badges72 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

thyago stall · Accepted Answer · 2015-12-21 07:02:53Z

1

Check out the some function call. It certainly is a function being passed as parameters, so curly brackets are necessary.

answered Dec 21, 2015 at 7:02

thyago stall

1,7043 gold badges17 silver badges31 bronze badges

Comments

Yeldar Kurmangaliyev · Accepted Answer · 2015-12-21 07:03:52Z

1

.some() expects function as the parameter.
If you want to pass anonymous function, then use curly braces:

if (two.some(function(req) { return req.related == assign.rid; })) 
{
    if (one.some(function(iter) { return iter.rid == req.rid; })) 
    {
        iter.quantity++;
    } else {
        one.push(req);
    }
}

answered Dec 21, 2015 at 7:03

Yeldar Kurmangaliyev

34.3k13 gold badges64 silver badges104 bronze badges

Comments

Nishad K Ahamed · Accepted Answer · 2015-12-21 07:05:37Z

1

you are missing open/close braces {} inside function

writing a function should be like this:

$(function(){
//code
})

answered Dec 21, 2015 at 7:05

Nishad K Ahamed

1,39415 silver badges25 bronze badges

Comments

Sravan · Accepted Answer · 2015-12-21 07:08:51Z

1

The some function needs curly braces/(paranthesis) to be opened and closed, please read this link, this is a good explanation on the function.

answered Dec 21, 2015 at 7:08

Sravan

18.7k3 gold badges33 silver badges54 bronze badges

Comments

Nicholas F · Accepted Answer · 2015-12-21 07:09:47Z

1

You aren't calling your functions properly. You need brackets after defining the function's arguments.

For example this is what two.some should look like:

two.some(function(req){ req.related == assign.rid })

answered Dec 21, 2015 at 7:09

Nicholas F

1414 bronze badges

Collectives™ on Stack Overflow

unexpected identifier error in javascript

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related