How to use foreach inside string in c#?

Question

I am trying to create a HTML Email Template with table in c# . For the same i used string and trying to concatenate the HTML tags. Now i have to add values from List as table data but not able to add the foreach loop inside string ..Below is my code..

EmailFormat += "<table><thead><tr><th>FirstName</th><th>LastName</th><th>Id</th><th>Date</th></thead>" 
+ foreach(Notification pReview in Review)
   {

   }
+ "</table>";

How can I do this?

Amit · Accepted Answer · 2015-12-22 06:59:55Z

3

foreach is a Statement, not an Expression. You can't use statements inside expressions.

It' fairly easy to solve though:

EmailFormat += "<table><thead><tr><th>FirstName</th><th>LastName</th><th>Id</th><th>Date</th></thead>";
foreach(Notification pReview in Review)
{
  EmailFormat += /*anything you want to add...*/;
}
EmailFormat += "</table>";

Or better yet, use a StringBuilder to construct your string.

answered Dec 22, 2015 at 6:59

Amit

46.5k9 gold badges84 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Matthew Watson Over a year ago

Also note that in .Net 4.5 or later you can use String.Concat<T>(IEnumerable<T>) to concatenate all the pReview.ToString() values rather than explicitly using foreach.

Amit Over a year ago

@MatthewWatson - It's not clear what is being concatenated but I'd imagine it involves a combination of instance properties and static string (to generate table rows markup). It guess it would be cleaner to use StringBuilder.AppendFormat for this task vs. mapping pReviews to strings.

Matthew Watson Over a year ago

Of course; I just meant that if they were doing EmailFormat += Review; then they could use string.Concat()

Lonli-Lokli · Accepted Answer · 2015-12-22 07:01:26Z

2

Try this

EmailFormat += "<table><thead><tr><th>FirstName</th><th>LastName</th><th>Id</th><th>Date</th></thead>" + string.Concat(Review.Select(_ => _.{Anything})) +  "</table>";

answered Dec 22, 2015 at 7:01

Lonli-Lokli

3,8161 gold badge32 silver badges42 bronze badges

Comments

Shaminder Singh · Accepted Answer · 2015-12-22 07:18:50Z

2

You can use StringBuilder for the same task, as its better when concatenating strings. For example

        StringBuilder EmailFormat = new StringBuilder();
        EmailFormat.Append("<table><thead><tr><th>FirstName</th><th>LastName</th><th>Id</th><th>Date</th></thead>");
        foreach (Notification pReview in Review)
        {
            EmailFormat.Append("<tr><td>pReview.FirstName</td><td>pReview.LastName</td><td>pReview.Date</td></tr>");
        }
        EmailFormat.Append("</table>");

Then Convert EmailFormat to String for further use.

edited Dec 22, 2015 at 7:18

answered Dec 22, 2015 at 7:05

Shaminder Singh

1,2932 gold badges18 silver badges31 bronze badges

Comments

Chen Kinnrot · Accepted Answer · 2015-12-22 07:00:44Z

1

Use a StringBuilder with his method append. this way you can build the string in parts se example here

answered Dec 22, 2015 at 7:00

Chen Kinnrot

21.1k18 gold badges82 silver badges142 bronze badges

Collectives™ on Stack Overflow

How to use foreach inside string in c#?

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related