Microsoft C++ exception: std::out_of_range error?

Question

I keep getting the following error:

Unhandled exception at 0x74BDD8A8 in FileName.exe: Microsoft C++ exception: std::out_of_range at memory location 0x004FA55C.

I've done some searching but I was not able to solve this problem. I did narrow it down to the fact that the out of range error is coming from my string fdata variable. Here is my code where error/exception occurs:

void MyClass::MyMethod10()
{
    string fdata;
    char num[100];
    int i = 0,k=0;
    unsigned int m,j=0;

    inputFile.open("sec1.txt", ios::in);
    inputFile >> fdata;
    while (j<fdata.length())
    {
       while (fdata.at(j) != '+')
       {
          if (fdata.at(j) != '*' && j<fdata.length())
          {
            num[k] = fdata.at(j);
            k++;
          }
          else
          {
             num[k] = '\0';
             m = atoi(num);
             //cout << m << endl;
             MyMethod22(m);
             k = 0;
          }
          j++;
       }
       MyMethod22(43);
       j++;  
   }
   inputFile.close();
   outputFile.open("sec2.txt", ios::out);
   while (i<index)
   {
     outputFile << (char)data[i];
     i++;
   }
   outputFile.close();
   CleanBuffer();
}

The sec1.txt file contains the following data

25750*23084*57475*15982*+57475*15982*+13364*15982*26260*+48840*32397*13364*15982*57475*11371*21876*+25197*

In the while() loop section my program is able to read the data correctly from the file. The problem/error/exception occurs at the point where my program takes in the last number from the file. I am guessing the problem is in the while() loop, but I am not able to figure out what's wrong. All I was able to do was to narrow down the error to string fdata being out of range after it reads the last number from the file. I was wondering if anyone can help me to solve this or suggest something which I might have missed?

MSVC++ has an option in the debug menu, "break on exceptions". — MSalters
– MSalters, Commented Dec 22, 2015 at 23:33

Ishamael · Accepted Answer · 2015-12-22 23:33:36Z

6

The actual problem you have is here:

   while (fdata.at(j) != '+')
   {
      ...
      j++;
   }

Note that you increment j, and try to read j-th character before you check if j is in range. To fix it, change it like this:

   while (j < fdata.size() && fdata.at(j) != '+')
   {
      ...
      j++;
   }

answered Dec 22, 2015 at 23:33

Ishamael

12.8k4 gold badges38 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user4925 Over a year ago

Thank you @ Ishamael and @mathematician1975 =. My problem is solved.

Collectives™ on Stack Overflow

Microsoft C++ exception: std::out_of_range error?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related