Min max value in javascript, no errors showing, but code doesn't work

Question

I'm really new to this, no errors are showing up, but code doesn't work. Trying to get the min and max value of numbers entered in the text-box.

here's the code:

<html lang="en">

<body>
  <h1>Problem JavaScript</h1>
  Enter a series of numbers with spaces in between each:
  <input type="text" name="qty1" id="qty"/>
  <button type="button" onclick="calculate();">Enter</button>
</body>
</html

function calculate(){

var numInput = getElementById("qty");
var numArray = numInput.split(" ");

document.write('Min value is:', Math.min.apply(null, numArray));
document.write('Max value is:', Math.max.apply(null, numArray));
}

Are you sure you posted your full HTML?

Andrew Brooke
– Andrew Brooke

2016-01-01 00:47:42 +00:00
Commented Jan 1, 2016 at 0:47 — Andrew Brooke
– Andrew Brooke, Commented Jan 1, 2016 at 0:47
Paste your full HTML code. I see a HTML tag without closing

Phiter
– Phiter

2016-01-01 01:09:13 +00:00
Commented Jan 1, 2016 at 1:09 — Phiter
– Phiter, Commented Jan 1, 2016 at 1:09

Andrew Brooke · Accepted Answer · 2016-01-01 00:55:44Z

2

You almost got it.

1.) getElementById should be document.getElementById. See document.getElementById() VS. getElementById()

2.) Calling .split on the element returned by getElementById isn't going to work, you need to do that to the element's value. ie:

var numInput = document.getElementById("qty").value;
var numArray = numInput.split(" ");

Here's a full example

function calculate() {
  var numInput = document.getElementById("qty").value;
  var numArray = numInput.split(" ");

  document.write('Min value is:', Math.min.apply(null, numArray));
  document.write('Max value is:', Math.max.apply(null, numArray));
}

<h1> Problem JavaScript</h1> Enter a series of numbers with spaces in between each:
<input type="text" id="qty">
<input type="button" id="go" value="Go" onclick="calculate()">

answered Jan 1, 2016 at 0:55

Andrew Brooke

12.2k8 gold badges41 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

newbieDeveloper Over a year ago

Face palm moment with the document.getElementById...Thanks so much! been staring at it for a while and couldn't figure it out....

Andrew Brooke Over a year ago

Of course! Consider marking this answer as correct to help people find it in the future

newbieDeveloper Over a year ago

to get the sum..i tried math.sum but that didn't work..will i need to use the .reduce?

Andrew Brooke Over a year ago

.reduce will work, but as it stands, your array is actually an array of strings, not integers. So, you'll need to map it to integers first. Check out this fiddle: jsfiddle.net/q9d6urkr

newbieDeveloper Over a year ago

Thank you so much for the help..i looked at .map and .reduce but couldn't figure out how to write it to work

Collectives™ on Stack Overflow

Min max value in javascript, no errors showing, but code doesn't work

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related