Laravel relationship count()

Question

I want to get a total user transaction (specific user) with relationship. I've done it but i'm curious is my way is good approach.

//User Model
public function Transaction()
{
    return $this->hasMany(Transaction::class);
}

//Merchant Model

public function Transaction()
{
    return $this->hasMany(Transaction::class);
}

public function countTransaction()
{
    return $this->hasOne(Transaction::class)
        ->where('user_id', Request::get('user_id'))
        ->groupBy('merchant_id');
}

public function getCountTransactionAttribute()
{
    if ($this->relationLoaded('countTransaction'))
        $this->load('countTransaction');

    $related = $this->getRelation('countTransaction');

    return ($related) ? (int)$related->total_transaction : 0;
}

//controller

$merchant = Merchant::with('countTransaction')->get();

What make me curious is part inside countTransaction. I put where where('user_id', Request::get('user_id')) directly inside the model.

is it good approach or any other way to get specific way?

expected result:

"merchant:"{
    "name": "example"
    "username" : "example"
    "transactions": {
        "count_transactions: "4" //4 came from a specific user.
    }
}

I need to get the merchant data with the transaction count for specific user. This query is based on logged in user. so when a user access merchant page, they can see their transaction count for that merchant.

Thanks.

Is Merchant your user? Or do you have an actual User model? — tptcat
– tptcat, Commented Jan 4, 2016 at 5:11
I have an actual user. 3 table. users, merchants, and transactions — ssuhat
– ssuhat, Commented Jan 4, 2016 at 5:12
And do you simply want to count the # of transactions for a specific user? I'm trying to understand how Merchant plays into this. — tptcat
– tptcat, Commented Jan 4, 2016 at 5:15

Chris · Accepted Answer · 2016-01-04 08:06:43Z

1

You really want to keep request data outside of your models (instead opting to pass it in). I'm also a little confused about why you have both a 'hasOne' for transactions, and a 'hasMany' for transactions within the merchant model.

I would probably approach the problem more like the below (untested, but along these lines). Again I'm not fully sure I understand what you need, but along these lines

    // Merchant Model
    public function transactions()
    {
        return $this->hasMany(Transaction::class);
    }

    public function countTransactionsByUser($userId)
    {
        return $this
                ->transactions()
                ->where('user_id', $userId)
                ->get()
                ->pluck('total_transaction')
                ->sum();
    }

    // Controller

    $userId = request()->get('user_id');

    // ::all() or however you want to reduce 
    // down the Merchant collection
    //
    $merchants = Merchant::all()->map(function($item, $key) {
        $_item = $item->getAttributes();
        $_item['transactions'] = [
            'count_transactions' => $item->countTransactionsByUser($userId);
        ];
        return $_item;
    });

    // Single total
    // Find merchant 2, and then get the total transactions 
    // for user 2
    //
    $singleTotal = Merchant::find(2)
        ->countTransactionsByUser($userId);

edited Jan 4, 2016 at 8:06

answered Jan 4, 2016 at 7:12

Chris

58.9k34 gold badges158 silver badges198 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

ssuhat Over a year ago

Hi, thanks for trying to understand my question. The reason i make 2 transactions is: countTransaction will return one value not array. that's why i make it hasOne instead of using hasMany. I've tried your solution using $singleTotal it's great but I can't get merchant result. Thanks

Chris Over a year ago

Could you post the result you did get?

ssuhat Over a year ago

result: [10]. I've update my question hope can be more understandable.

This query is based on logged in user. so when a user access merchant page, they can see their transaction count for that merchant.

Chris Over a year ago

What is the output of the first command (the map one)? The intended output of the second, would be a single number (in this case 10)

ssuhat Over a year ago

[   {     "id": 1,     "name": "merchant 1",      "transactions": [10]    }    {            "id": 2,     "name": "Merchant 2",      "transactions": [3]    } ]

|

Collectives™ on Stack Overflow

Laravel relationship count()

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related