Visual Studio Button code error

Question

This is my first time using visual studio and I'm running into an error with my tax calulator application. The problem is that visual studio is saying that the multiplication line using "*" and "+" can not be done due to the variables being text boxes. So my question to the community, is should I change the text box to something else? Or where in my code did I mess up.

Public Class Form1
    Private Sub btnCalc_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCalc.Click
        If (IsNumeric(txtSale) And IsNumeric(txtSalesTaxRate)) Then
            lblTax = txtSale * txtSalesTaxRate
            lblTotal = txtSale + lblTax
        Else
            MsgBox("Please enter valid numbers, thank you!")
        End If

    End Sub
End Class

If you need me to give you the full layout of my application, do ask.

You are reference the textbox not the Text property. Use txtSale.Text instead — Mark Hall
– Mark Hall, Commented Jan 5, 2016 at 21:03
Remember the .Text property for your labels as well, so that your tax and total will be displayed — ImDeveloping
– ImDeveloping, Commented Jan 5, 2016 at 21:31

Reznicencu Bogdan · Accepted Answer · 2016-01-06 11:00:16Z

1

I can see multiple problems in your code. I will explain how the "vs" works.The textboxes that you've made are controls.
You can't just take their value so simple.They have many property and one of them is .text which allows you to take the value inside them.
Another mistake you've made is what you've tried to do with the textboxes.What you type in those textboxes is ..well text. The program can't tell if the value inside is a number or just text. You must convert that value in a number using Cint.
So you're code will look like this:

Public Class Form1
Private Sub btnCalc_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCalc.Click
    If (IsNumeric(txtSale.text) And IsNumeric(txtSalesTaxRate.text)) Then
        lblTax.text= cint(txtSale.text) * cint(txtSalesTaxRate.text)
        lblTotal.text= cint(txtSale.text) + cint(lblTax.text)
    Else
        MsgBox("Please enter valid numbers, thank you!")
    End If

End Sub
End Class

What cint does is to convert every type of data to integer. Also the .text property lets you to set the value of the control (in our case the label caption)

edited Jan 6, 2016 at 11:00

answered Jan 6, 2016 at 0:00

Reznicencu Bogdan

9002 gold badges11 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Visual Vincent Over a year ago

.Text is not a function, it's a property. Just a little perfectionist's note. ;)

Ňɏssa Pøngjǣrdenlarp Over a year ago

.Text is not a function, it is a Property. And converting a Tax Rate to integer may be incorrect if it has decimals. Other text may fail if the user enters other chars, so TryParse should be used

Relogical · Accepted Answer · 2016-01-06 15:00:32Z

1

I tried Electric-web's code and ran into a problem with the output. I changed "CInt" to "CDbl" and the tax calculator worked.

    Public Class Form1
Private Sub btnCalc_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCalc.Click
    If (IsNumeric(txtSale.text) And IsNumeric(txtSalesTaxRate.text)) Then
        lblTax.text= cdbl(txtSale.text) * cdbl(txtSalesTaxRate.text)
        lblTotal.text= cdbl(txtSale.text) + cdbl(lblTax.text)
    Else
        MsgBox("Please enter valid numbers, thank you!")
    End If

End Sub
End Class

answered Jan 6, 2016 at 15:00

Relogical

391 silver badge5 bronze badges

1 Comment

Reznicencu Bogdan Over a year ago

You can also try convert.ToInt or to double is you want the numbers not to be rounded

Collectives™ on Stack Overflow

Visual Studio Button code error

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related